Capture engine/run unit tests with prysk #3592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine with existing Topological Deps integration tests.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
🟢 CI successful 🟢Thanks |
| @@ -24,3 +24,19 @@ Check my-app#build output | |||
| Cached: 0 cached, 2 total | |||
| Time:\s*[\.0-9]+m?s (re) | |||
|
|
|||
|
|
|||
|
|
|||
| Graph | |||
There was a problem hiding this comment.
What's the goal of this test? I'm not really that well versed in this part of the codebase.
There was a problem hiding this comment.
This is merged in from here: https://github.com/vercel/turbo/blob/main/cli/integration_tests/topological_deps/graph.t
The underlying config is:
{
"$schema": "https://turbo.build/schema.json",
"pipeline": {
"build": {
"dependsOn": ["^build"]
},
"//#build": {
"dependsOn": []
}
}
}So I think the idea is to validate that the task graph is generated correctly
Co-authored-by: Nicholas Yang <nicholas.yang@vercel.com>
NicholasLYang
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts more unit tests to integration tests. The purpose of this change is to make it easier to land #3562, which breaks all these unit tests, and it's a lot of unnecessary work to fix as unit tests. Additionally, because we're lazy loading task definitions in that PR, these unit tests would need access to a file system, breaking their "unit" nature, anyway.
--graph, because that's what the underlying tests were doing also. I could execute, but parallel execution makes it a bit more challenging to assert against logs.topological-depsintegration tests.Previous similar work: