这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(shim): better error message for missing go bin #3498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 27, 2023
Merged

fix(shim): better error message for missing go bin #3498

merged 2 commits into from
Jan 27, 2023

Conversation

tknickman
Copy link
Member

No description provided.

@tknickman tknickman requested review from a team as code owners January 26, 2023 16:15
@vercel
Copy link

vercel bot commented Jan 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

10 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 26, 2023 at 5:26PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 26, 2023 at 5:26PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 26, 2023 at 5:26PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 26, 2023 at 5:26PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 26, 2023 at 5:26PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 26, 2023 at 5:26PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 26, 2023 at 5:26PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 26, 2023 at 5:26PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Jan 26, 2023 at 5:26PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Jan 26, 2023 at 5:26PM (UTC)

@tknickman tknickman force-pushed the tomknickman/turbo-699-improve-shim-error-message-when-it-cant branch from 4b28ae7 to 7dcc6b2 Compare January 26, 2023 16:16
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

NicholasLYang
NicholasLYang reviewed Jan 26, 2023
View reviewed changes
@github-actions
Copy link
Contributor

Benchmark for d2afaf0

Test Base PR % Significant %
bench_startup/Turbopack SSR/1000 modules 1733.43ms ± 3.89ms 1750.78ms ± 4.31ms +1.00% +0.05%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8075.58µs ± 31.99µs 8028.78µs ± 41.93µs -0.58%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8435.69µs ± 62.38µs 8441.02µs ± 50.51µs +0.06%
bench_hmr_to_commit/Turbopack RSC/1000 modules 454.02ms ± 3.07ms 455.76ms ± 1.70ms +0.38%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8252.30µs ± 69.43µs 8325.47µs ± 59.18µs +0.89%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7276.62µs ± 59.34µs 7191.96µs ± 41.48µs -1.16%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7432.18µs ± 78.15µs 7484.38µs ± 35.24µs +0.70%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7299.15µs ± 44.85µs 7357.58µs ± 43.25µs +0.80%
bench_hydration/Turbopack RCC/1000 modules 3175.43ms ± 7.94ms 3191.91ms ± 14.84ms +0.52%
bench_hydration/Turbopack RSC/1000 modules 2765.68ms ± 8.92ms 2778.00ms ± 8.22ms +0.45%
bench_hydration/Turbopack SSR/1000 modules 2592.54ms ± 8.30ms 2591.94ms ± 11.15ms -0.02%
bench_startup/Turbopack CSR/1000 modules 1635.93ms ± 4.99ms 1675.35ms ± 24.18ms +2.41%
bench_startup/Turbopack RCC/1000 modules 2145.24ms ± 6.70ms 2157.47ms ± 7.57ms +0.57%
bench_startup/Turbopack RSC/1000 modules 2054.57ms ± 6.17ms 2057.66ms ± 6.92ms +0.15%
bench_startup/Turbopack SSR/1000 modules 1733.43ms ± 3.89ms 1750.78ms ± 4.31ms +1.00% +0.05%

@github-actions
Copy link
Contributor

Benchmark for 0850214

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8073.28µs ± 78.62µs 8015.97µs ± 60.89µs -0.71%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8354.80µs ± 41.00µs 8426.68µs ± 36.80µs +0.86%
bench_hmr_to_commit/Turbopack RSC/1000 modules 449.31ms ± 3.24ms 450.34ms ± 1.12ms +0.23%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8259.68µs ± 77.46µs 8172.10µs ± 55.19µs -1.06%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7129.36µs ± 37.82µs 7107.92µs ± 36.99µs -0.30%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7344.06µs ± 69.38µs 7367.14µs ± 41.23µs +0.31%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7256.12µs ± 39.51µs 7274.78µs ± 47.71µs +0.26%
bench_hydration/Turbopack RCC/1000 modules 3192.94ms ± 11.96ms 3205.18ms ± 17.58ms +0.38%
bench_hydration/Turbopack RSC/1000 modules 2775.33ms ± 8.20ms 2771.56ms ± 4.22ms -0.14%
bench_hydration/Turbopack SSR/1000 modules 2613.45ms ± 8.40ms 2598.63ms ± 8.24ms -0.57%
bench_startup/Turbopack CSR/1000 modules 1624.98ms ± 4.93ms 1607.07ms ± 5.89ms -1.10%
bench_startup/Turbopack RCC/1000 modules 2149.94ms ± 4.57ms 2147.77ms ± 4.84ms -0.10%
bench_startup/Turbopack RSC/1000 modules 2054.56ms ± 9.12ms 2061.00ms ± 4.58ms +0.31%
bench_startup/Turbopack SSR/1000 modules 1746.83ms ± 4.86ms 1749.27ms ± 4.49ms +0.14%

@tknickman tknickman merged commit 65beb2c into main Jan 27, 2023
@tknickman tknickman deleted the tomknickman/turbo-699-improve-shim-error-message-when-it-cant branch January 27, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasLYang NicholasLYang NicholasLYang approved these changes

@arlyon arlyon Awaiting requested review from arlyon arlyon is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tknickman @NicholasLYang