这是indexloc提供的服务，不要输入任何密码
Skip to content

examples/basic is using PNPM, not Yarn #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2023
Merged

examples/basic is using PNPM, not Yarn #3488

merged 2 commits into from
Feb 6, 2023

Conversation

ImBIOS
Copy link
Contributor

@ImBIOS ImBIOS commented Jan 26, 2023

This project example uses PNPM as the package manager, but the README.md guide uses PNPM at first and Yarn for the rest of the command docs.

@ImBIOS ImBIOS requested a review from a team as a code owner January 26, 2023 05:44
@vercel
Copy link

vercel bot commented Jan 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 10:42AM (UTC)
examples-cra-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 10:42AM (UTC)
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 10:42AM (UTC)
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 10:42AM (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 10:42AM (UTC)
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 10:42AM (UTC)
examples-tailwind-web 🔄 Building (Inspect) Visit Preview Feb 6, 2023 at 10:42AM (UTC)
examples-vite-web 🔄 Building (Inspect) Visit Preview 💬 Add your feedback Feb 6, 2023 at 10:42AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
examples-kitchensink-blog ⬜️ Ignored (Inspect) Feb 6, 2023 at 10:42AM (UTC)

@github-actions github-actions bot added the area: examples Improvements or additions to examples label Jan 26, 2023
@vercel
Copy link

vercel bot commented Jan 26, 2023

@ImBIOS is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ImBIOS ImBIOS changed the title example/basic is using PNPM, not Yarn (This is a little fix for README.md) examples/basic is using PNPM, not Yarn (This is a little fix for README.md) Jan 26, 2023
mehulkar
mehulkar approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@mehulkar mehulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you!

@mehulkar mehulkar added the pr: automerge Kodiak will merge these automatically after checks pass label Jan 26, 2023
@ImBIOS
Copy link
Contributor Author

ImBIOS commented Jan 26, 2023

Happy to contribute 👍

@mehulkar mehulkar enabled auto-merge (squash) February 6, 2023 10:41
@mehulkar mehulkar disabled auto-merge February 6, 2023 10:41
@mehulkar mehulkar changed the title examples/basic is using PNPM, not Yarn (This is a little fix for README.md) examples/basic is using PNPM, not Yarn Feb 6, 2023
@mehulkar mehulkar enabled auto-merge (squash) February 6, 2023 10:42
@mehulkar mehulkar merged commit 6f38d98 into vercel:main Feb 6, 2023
@ImBIOS ImBIOS deleted the patch-1 branch February 7, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehulkar mehulkar mehulkar approved these changes

@nathanhammond nathanhammond Awaiting requested review from nathanhammond nathanhammond is a code owner automatically assigned from vercel/turbo-oss

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: examples Improvements or additions to examples pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ImBIOS @mehulkar