这是indexloc提供的服务,不要输入任何密码
Skip to content

decode magic identifiers in error overlay #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ForsakenHarmony
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Jan 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-svelte-web 🔄 Building (Inspect) Jan 23, 2023 at 3:58PM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 23, 2023 at 3:58PM (UTC)
8 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 23, 2023 at 3:58PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 23, 2023 at 3:58PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 23, 2023 at 3:58PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 23, 2023 at 3:58PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 23, 2023 at 3:58PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 23, 2023 at 3:58PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 23, 2023 at 3:58PM (UTC)
turbo-vite-web ⬜️ Ignored (Inspect) Jan 23, 2023 at 3:58PM (UTC)

@ForsakenHarmony
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions
Copy link
Contributor

Benchmark for ccd2996

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 7638.08µs ± 57.38µs 7625.79µs ± 50.51µs -0.16%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8095.13µs ± 83.10µs 7980.38µs ± 36.79µs -1.42%
bench_hmr_to_commit/Turbopack RSC/1000 modules 449.99ms ± 1.37ms 451.92ms ± 1.11ms +0.43%
bench_hmr_to_commit/Turbopack SSR/1000 modules 7894.19µs ± 62.31µs 7784.61µs ± 42.22µs -1.39%
bench_hmr_to_eval/Turbopack CSR/1000 modules 6679.23µs ± 33.58µs 6766.40µs ± 50.52µs +1.31%
bench_hmr_to_eval/Turbopack RCC/1000 modules 6934.94µs ± 70.24µs 6976.48µs ± 38.62µs +0.60%
bench_hmr_to_eval/Turbopack SSR/1000 modules 6906.12µs ± 62.88µs 6910.88µs ± 52.88µs +0.07%
bench_hydration/Turbopack RCC/1000 modules 3313.33ms ± 7.93ms 3322.30ms ± 14.27ms +0.27%
bench_hydration/Turbopack RSC/1000 modules 2781.73ms ± 12.03ms 2783.78ms ± 7.50ms +0.07%
bench_hydration/Turbopack SSR/1000 modules 2601.64ms ± 8.02ms 2583.92ms ± 6.67ms -0.68%
bench_startup/Turbopack CSR/1000 modules 1607.24ms ± 4.54ms 1621.44ms ± 7.79ms +0.88%
bench_startup/Turbopack RCC/1000 modules 2458.28ms ± 7.52ms 2455.72ms ± 7.97ms -0.10%
bench_startup/Turbopack RSC/1000 modules 2353.65ms ± 11.94ms 2373.65ms ± 8.01ms +0.85%
bench_startup/Turbopack SSR/1000 modules 2027.28ms ± 3.11ms 2028.49ms ± 3.90ms +0.06%

@github-actions
Copy link
Contributor

🟢 CI successful 🟢

Thanks

@ForsakenHarmony ForsakenHarmony marked this pull request as ready for review January 25, 2023 13:47
@ForsakenHarmony ForsakenHarmony requested a review from a team as a code owner January 25, 2023 13:47
Copy link
Contributor

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this look like?

@ForsakenHarmony
Copy link
Contributor Author

ForsakenHarmony commented Jan 25, 2023

@jridgewell

TypeError: {imported module [project-with-next]/apps/vercel-site/lib/sentry.ts}.withScope is not a function

instead of

TypeError: __TURBOPACK__imported__module__$5b$project$2d$with$2d$next$5d2f$apps$2f$vercel$2d$site$2f$lib$2f$sentry$2e$ts__.withScope is not a function

@ForsakenHarmony ForsakenHarmony merged commit 34ffb98 into main Jan 26, 2023
@ForsakenHarmony ForsakenHarmony deleted the hrmny/web-430-error-overlay-decode-magic-identifiers branch January 26, 2023 16:50
ijjk pushed a commit to vercel/next.js that referenced this pull request Jan 26, 2023
**Note**: This requires #45314,
otherwise the following error is shown, but does not block builds:

```
error - [build] examples/create-app
  Error evaluating Node.js code
  TypeError: makeResolver is not a function
    at getResolveRoute (path/to/next.js/examples/create-app/.next/build/chunks/router.js:21:18)
    at async Module.route (path/to/next.js/examples/create-app/.next/build/chunks/router.js:24:36)
    at async Module.run (path/to/next.js/examples/create-app/.next/build/chunks/[turbopack-node]_ipc_evaluate.ts.js:19:39)
```

### Features

- vercel/turborepo#3446
- vercel/turborepo#3396
- vercel/turborepo#3499

### Bug fixes

- vercel/turborepo#3433

### Misc

- vercel/turborepo#3479
jridgewell pushed a commit to vercel/next.js that referenced this pull request Mar 10, 2023
sokra pushed a commit to vercel/next.js that referenced this pull request Mar 13, 2023
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 25, 2024
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Jul 29, 2024
ForsakenHarmony added a commit to vercel/next.js that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants