这是indexloc提供的服务，不要输入任何密码
Skip to content

feat(turbo-test-utils): share internal test utils #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2023
Merged

feat(turbo-test-utils): share internal test utils #3418

merged 1 commit into from
Jan 23, 2023

Conversation

tknickman
Copy link
Member

This is an inconsequential PR, but in the turbo-codemod rewrite I borrowed some test utils that I wrote for turbo-ignore. This revisits that and abstracts them to a shared turbo-test-utils package instead of duplicating them (we're a monorepo tool, let's practice what we preach)

@tknickman tknickman requested review from a team as code owners January 21, 2023 20:49
@vercel
Copy link

vercel bot commented Jan 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-cra-web 🔄 Building (Inspect) Jan 23, 2023 at 6:20PM (UTC)
examples-tailwind-web 🔄 Building (Inspect) Jan 23, 2023 at 6:20PM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 23, 2023 at 6:20PM (UTC)
7 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 23, 2023 at 6:20PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 23, 2023 at 6:20PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 23, 2023 at 6:20PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 23, 2023 at 6:20PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 23, 2023 at 6:20PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 23, 2023 at 6:20PM (UTC)
turbo-vite-web ⬜️ Ignored (Inspect) Jan 23, 2023 at 6:20PM (UTC)

@github-actions github-actions bot added the pkg: turbo-ignore packages/turbo-ignore label Jan 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@github-actions
Copy link
Contributor

Benchmark for 8c30c8d

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8239.98µs ± 65.17µs 8173.88µs ± 40.84µs -0.80%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8461.95µs ± 78.70µs 8455.37µs ± 53.12µs -0.08%
bench_hmr_to_commit/Turbopack RSC/1000 modules 470.53ms ± 2.60ms 465.42ms ± 3.30ms -1.09%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8301.27µs ± 62.34µs 8237.90µs ± 68.98µs -0.76%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7356.27µs ± 68.47µs 7243.18µs ± 34.90µs -1.54%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7361.10µs ± 67.46µs 7400.18µs ± 44.37µs +0.53%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7362.90µs ± 56.07µs 7298.93µs ± 50.33µs -0.87%
bench_hydration/Turbopack RCC/1000 modules 3440.85ms ± 12.43ms 3457.44ms ± 10.65ms +0.48%
bench_hydration/Turbopack RSC/1000 modules 2868.73ms ± 9.13ms 2882.37ms ± 9.63ms +0.48%
bench_hydration/Turbopack SSR/1000 modules 2655.99ms ± 8.65ms 2658.42ms ± 8.94ms +0.09%
bench_startup/Turbopack CSR/1000 modules 1665.13ms ± 5.55ms 1657.22ms ± 5.45ms -0.48%
bench_startup/Turbopack RCC/1000 modules 2548.90ms ± 9.61ms 2562.50ms ± 6.20ms +0.53%
bench_startup/Turbopack RSC/1000 modules 2431.93ms ± 10.47ms 2432.44ms ± 6.24ms +0.02%
bench_startup/Turbopack SSR/1000 modules 2091.15ms ± 6.27ms 2098.36ms ± 4.36ms +0.34%

@github-actions
Copy link
Contributor

Benchmark for 5656ab9

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 9436.95µs ± 1359.59µs 8207.35µs ± 85.23µs -13.03%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8399.84µs ± 72.85µs 8408.54µs ± 74.35µs +0.10%
bench_hmr_to_commit/Turbopack RSC/1000 modules 441.93ms ± 2.84ms 437.26ms ± 1.83ms -1.06%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8260.97µs ± 48.74µs 8279.24µs ± 88.09µs +0.22%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7225.40µs ± 34.18µs 7384.07µs ± 92.97µs +2.20%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7331.88µs ± 67.69µs 7364.38µs ± 53.58µs +0.44%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7267.10µs ± 68.19µs 7307.35µs ± 80.71µs +0.55%
bench_hydration/Turbopack RCC/1000 modules 3373.06ms ± 8.70ms 3352.58ms ± 8.18ms -0.61%
bench_hydration/Turbopack RSC/1000 modules 2804.22ms ± 3.19ms 2799.67ms ± 10.00ms -0.16%
bench_hydration/Turbopack SSR/1000 modules 2615.75ms ± 12.40ms 2614.06ms ± 10.18ms -0.06%
bench_startup/Turbopack CSR/1000 modules 1621.21ms ± 3.11ms 1633.67ms ± 9.28ms +0.77%
bench_startup/Turbopack RCC/1000 modules 2481.75ms ± 7.84ms 2475.91ms ± 5.72ms -0.24%
bench_startup/Turbopack RSC/1000 modules 2370.93ms ± 9.02ms 2363.88ms ± 8.74ms -0.30%
bench_startup/Turbopack SSR/1000 modules 2049.55ms ± 3.65ms 2049.14ms ± 3.76ms -0.02%

mehulkar
mehulkar approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@mehulkar mehulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@tknickman tknickman merged commit 3b2377a into main Jan 23, 2023
@tknickman tknickman deleted the turbo-test-utils branch January 23, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehulkar mehulkar mehulkar approved these changes

@nathanhammond nathanhammond Awaiting requested review from nathanhammond nathanhammond is a code owner automatically assigned from vercel/turbo-oss

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
pkg: turbo-ignore packages/turbo-ignore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tknickman @mehulkar