这是indexloc提供的服务，不要输入任何密码
Skip to content

Correctly hash empty outputs first #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Correctly hash empty outputs first #341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions cli/internal/run/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,13 @@ func (c *RunCommand) Run(args []string) int {
// override if we need to...
pipeline = altpipe
}
outputs := []string{fmt.Sprintf(".turbo/turbo-%v.log", task)}
if len(pipeline.Outputs) > 0 {
outputs = append(outputs, pipeline.Outputs...)
} else {
outputs = append(outputs, "dist/**/*", "build/**/*")
}

hashable := struct {
Hash string
Task string
Expand All @@ -422,7 +429,7 @@ func (c *RunCommand) Run(args []string) int {
}{
Hash: pack.Hash,
Task: task,
Outputs: pipeline.Outputs,
Outputs: outputs,
PassThruArgs: runOptions.passThroughArgs,
}
hash, err := fs.HashObject(hashable)
Expand All @@ -438,13 +445,6 @@ func (c *RunCommand) Run(args []string) int {
// We create the real task outputs now so we can potentially use them to
// to store artifacts from remote cache to local fs cache

outputs := []string{fmt.Sprintf(".turbo/turbo-%v.log", task)}
if len(pipeline.Outputs) > 0 {
outputs = append(outputs, pipeline.Outputs...)
} else {
outputs = append(outputs, "dist/**/*", "build/**/*")
}

var hit bool
if runOptions.forceExecution {
hit = false
Expand Down