这是indexloc提供的服务,不要输入任何密码
Skip to content

Refactor Task Definition retrieval to support composable configs #3405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented Jan 20, 2023

In order to create composable configs, we need to calculate Task dependencies and topological dependencies when iterating per-workspace. Currently this happens too early.

This PR moves just topological dependencies, because there is no business logic around them. In a future PR, I will also move task dependencies over once. This refactor should not affect that.

Reviewing commits one at a time will probably be best here.

@mehulkar mehulkar requested a review from a team as a code owner January 20, 2023 20:46
@vercel
Copy link

vercel bot commented Jan 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 10:52PM (UTC)
examples-cra-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 10:52PM (UTC)
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 10:52PM (UTC)
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 10:52PM (UTC)
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 10:52PM (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 10:52PM (UTC)
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 10:52PM (UTC)
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 10:52PM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 10:52PM (UTC)
turbo-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 10:52PM (UTC)

This moves TopoDeps generation a bit later, when we're iterating tasks per workspace.
The advantage of this is that we will be able to calculate topological dependencies
per-workspace, so that composable configs can play a role in this.
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2023

🟢 CI successful 🟢

Thanks

@mehulkar mehulkar changed the title Refactor: Calculate Topological Dependencies when building per-workspace task queue Refactor Task Definition retrieval to support composable configs Jan 20, 2023
@mehulkar mehulkar enabled auto-merge (squash) January 20, 2023 22:51
@mehulkar mehulkar mentioned this pull request Feb 6, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants