fix: Support pnpm lockfile keys in dependencies #3461
Merged
+85
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
|
@chris-olszewski is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
tknickman
approved these changes
Jan 26, 2023
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Jan 26, 2023
Fixes vercel#3382 This PR adds support for when pnpm encodes a dependency version as a lockfile key instead of just a version. We already have similar logic in the npm lockfile implementation. Thanks to @omarahm3 for the reproduction!
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Jan 26, 2023
Fixes vercel#3382 This PR adds support for when pnpm encodes a dependency version as a lockfile key instead of just a version. We already have similar logic in the npm lockfile implementation. Thanks to @omarahm3 for the reproduction!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3382
This PR adds support for when pnpm encodes a dependency version as a lockfile key instead of just a version. We already have similar logic in the npm lockfile implementation.
Thanks to @omarahm3 for the reproduction!