这是indexloc提供的服务,不要输入任何密码
Skip to content

fix(release): use turbo to build packages #3454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2023
Merged

fix(release): use turbo to build packages #3454

merged 1 commit into from
Jan 24, 2023

Conversation

tknickman
Copy link
Member

We need to use turbo to build our packages because some of them now have internal dependencies that need to be built first.

@tknickman tknickman requested a review from a team as a code owner January 24, 2023 17:33
@vercel
Copy link

vercel bot commented Jan 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-designsystem-docs 🔄 Building (Inspect) Jan 24, 2023 at 5:36PM (UTC)
examples-svelte-web 🔄 Building (Inspect) Jan 24, 2023 at 5:36PM (UTC)
examples-tailwind-web 🔄 Building (Inspect) Jan 24, 2023 at 5:36PM (UTC)
7 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 24, 2023 at 5:36PM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 24, 2023 at 5:36PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 24, 2023 at 5:36PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 24, 2023 at 5:36PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 24, 2023 at 5:36PM (UTC)
examples-vite-web ⬜️ Ignored (Inspect) Jan 24, 2023 at 5:36PM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2023 at 5:36PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2023

🟢 CI successful 🟢

Thanks

cd $(CLI_DIR)/../packages/turbo-ignore && pnpm install --filter=turbo-ignore && pnpm run build
cd $(CLI_DIR)/../ && pnpm install --filter=create-turbo && pnpm turbo build --filter=create-turbo...
cd $(CLI_DIR)/../ && pnpm install --filter=@turbo/codemod && pnpm turbo build --filter=@turbo/codemod...
cd $(CLI_DIR)/../ && pnpm install --filter=turbo-ignore && pnpm turbo build --filter=turbo-ignore...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used --filter much. I see the ... documented here, but isn't this also default behavior? Or is it not default behavior when --filter is used?

Copy link
Member Author

@tknickman tknickman Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea good question, it's a little confusing, but there is a difference. However in practice it’s not usually applicable. Say you only have this in your turbo.json (no depends on):

"build": {
   "outputs": ["dist/**", ".next/**"]
 }

In this case, you will get different results depending on the filter.
For example:
turbo build --filter={app} will only build {app}.
But,
turbo build --filter={app}... will build {app} , and any workspace dependency listed in {app}’s package.json

However, if you had (the more common):

"build": {
   "dependsOn": ["^build"],
   "outputs": ["dist/**", ".next/**"]
 }

--filter={app} and --filter={app}... are going to behave the same.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh, thanks for that explanation, that makes sense

@tknickman tknickman merged commit 752b4dc into main Jan 24, 2023
@tknickman tknickman deleted the fix_publish_step branch January 24, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants