-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(release): use turbo to build packages #3454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
9cafb7e
to
e301887
Compare
🟢 CI successful 🟢Thanks |
cd $(CLI_DIR)/../packages/turbo-ignore && pnpm install --filter=turbo-ignore && pnpm run build | ||
cd $(CLI_DIR)/../ && pnpm install --filter=create-turbo && pnpm turbo build --filter=create-turbo... | ||
cd $(CLI_DIR)/../ && pnpm install --filter=@turbo/codemod && pnpm turbo build --filter=@turbo/codemod... | ||
cd $(CLI_DIR)/../ && pnpm install --filter=turbo-ignore && pnpm turbo build --filter=turbo-ignore... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't used --filter
much. I see the ...
documented here, but isn't this also default behavior? Or is it not default behavior when --filter
is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea good question, it's a little confusing, but there is a difference. However in practice it’s not usually applicable. Say you only have this in your turbo.json (no depends on):
"build": {
"outputs": ["dist/**", ".next/**"]
}
In this case, you will get different results depending on the filter.
For example:
turbo build --filter={app}
will only build {app}
.
But,
turbo build --filter={app}...
will build {app}
, and any workspace dependency listed in {app}
’s package.json
However, if you had (the more common):
"build": {
"dependsOn": ["^build"],
"outputs": ["dist/**", ".next/**"]
}
--filter={app}
and --filter={app}...
are going to behave the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh, thanks for that explanation, that makes sense
We need to use turbo to build our packages because some of them now have internal dependencies that need to be built first.