这是indexloc提供的服务，不要输入任何密码
Skip to content

ci(actions): ensure cargo check with frozen lockfile #3388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 20, 2023
Merged

ci(actions): ensure cargo check with frozen lockfile #3388

merged 4 commits into from
Jan 20, 2023
+1 −1

Conversation

kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Jan 19, 2023

Avoid cases like #3387

@vercel
Copy link

vercel bot commented Jan 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-kitchensink-blog 🔄 Building (Inspect) Jan 20, 2023 at 4:24AM (UTC)
examples-svelte-web 🔄 Building (Inspect) Jan 20, 2023 at 4:24AM (UTC)
turbo-site 🔄 Building (Inspect) Visit Preview Jan 20, 2023 at 4:24AM (UTC)
7 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 20, 2023 at 4:24AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 20, 2023 at 4:24AM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 20, 2023 at 4:24AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 20, 2023 at 4:24AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 20, 2023 at 4:24AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 20, 2023 at 4:24AM (UTC)
turbo-vite-web ⬜️ Ignored (Inspect) Jan 20, 2023 at 4:24AM (UTC)

@kwonoj kwonoj requested review from a team as code owners January 19, 2023 23:37
@kwonoj kwonoj requested review from mehulkar and tknickman January 19, 2023 23:37
@kwonoj kwonoj mentioned this pull request Jan 19, 2023
Merged
@kwonoj kwonoj force-pushed the frozen-cargo-ci-check branch from b80f250 to decf916 Compare January 19, 2023 23:43
@kwonoj kwonoj enabled auto-merge (squash) January 19, 2023 23:43
@github-actions
Copy link
Contributor

Benchmark for 4facc39

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8866.51µs ± 46.91µs 8762.96µs ± 63.65µs -1.17%
bench_hmr_to_commit/Turbopack RCC/1000 modules 9066.08µs ± 66.28µs 9092.54µs ± 59.88µs +0.29%
bench_hmr_to_commit/Turbopack RSC/1000 modules 463.27ms ± 3.05ms 455.28ms ± 1.52ms -1.72%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8886.69µs ± 46.97µs 8876.29µs ± 74.11µs -0.12%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7751.79µs ± 63.54µs 7820.45µs ± 43.60µs +0.89%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7850.79µs ± 50.19µs 7835.71µs ± 76.75µs -0.19%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7857.54µs ± 52.41µs 7816.11µs ± 66.24µs -0.53%
bench_hydration/Turbopack RCC/1000 modules 3344.64ms ± 13.77ms 3384.49ms ± 9.16ms +1.19%
bench_hydration/Turbopack RSC/1000 modules 2851.55ms ± 8.07ms 2858.32ms ± 12.47ms +0.24%
bench_hydration/Turbopack SSR/1000 modules 2689.75ms ± 10.99ms 2697.19ms ± 12.77ms +0.28%
bench_startup/Turbopack CSR/1000 modules 1661.62ms ± 4.02ms 1658.12ms ± 8.49ms -0.21%
bench_startup/Turbopack RCC/1000 modules 2517.28ms ± 12.70ms 2511.69ms ± 6.89ms -0.22%
bench_startup/Turbopack RSC/1000 modules 2396.57ms ± 7.69ms 2410.56ms ± 6.49ms +0.58%
bench_startup/Turbopack SSR/1000 modules 2066.89ms ± 4.61ms 2060.20ms ± 5.89ms -0.32%

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@kwonoj kwonoj added the pr: automerge Kodiak will merge these automatically after checks pass label Jan 20, 2023
@github-actions
Copy link
Contributor

Benchmark for b9c558e

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8055.13µs ± 46.07µs 8021.28µs ± 41.98µs -0.42%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8239.85µs ± 51.52µs 8325.88µs ± 58.29µs +1.04%
bench_hmr_to_commit/Turbopack RSC/1000 modules 445.04ms ± 1.41ms 443.55ms ± 1.65ms -0.33%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8135.99µs ± 59.53µs 8091.47µs ± 49.41µs -0.55%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7072.26µs ± 33.85µs 7052.13µs ± 73.71µs -0.28%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7281.71µs ± 62.37µs 7212.36µs ± 75.51µs -0.95%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7218.42µs ± 34.58µs 7219.77µs ± 62.87µs +0.02%
bench_hydration/Turbopack RCC/1000 modules 3230.48ms ± 9.14ms 3217.78ms ± 6.78ms -0.39%
bench_hydration/Turbopack RSC/1000 modules 2738.76ms ± 10.67ms 2750.00ms ± 8.39ms +0.41%
bench_hydration/Turbopack SSR/1000 modules 2595.12ms ± 10.13ms 2584.51ms ± 6.35ms -0.41%
bench_startup/Turbopack CSR/1000 modules 1610.31ms ± 2.92ms 1616.08ms ± 6.12ms +0.36%
bench_startup/Turbopack RCC/1000 modules 2457.98ms ± 10.06ms 2446.52ms ± 8.19ms -0.47%
bench_startup/Turbopack RSC/1000 modules 2342.04ms ± 4.05ms 2326.99ms ± 5.92ms -0.64%
bench_startup/Turbopack SSR/1000 modules 2020.63ms ± 4.02ms 2011.55ms ± 2.10ms -0.45%

@kwonoj kwonoj merged commit 23adb1d into main Jan 20, 2023
@kwonoj kwonoj deleted the frozen-cargo-ci-check branch January 20, 2023 04:40
sokra added a commit that referenced this pull request Jan 20, 2023
@sokra
Revert "ci(actions): ensure cargo check with frozen lockfile (#3388)"
8ff75dc 
This reverts commit 23adb1d.
@sokra sokra mentioned this pull request Jan 20, 2023
Merged
sokra added a commit that referenced this pull request Jan 20, 2023
@sokra
Revert "ci(actions): ensure cargo check with frozen lockfile" (#3390)
f28d705 
Reverts #3388
@sokra
Copy link
Member

sokra commented Jan 20, 2023 •
edited
Loading

@kwonoj I had to revert that. I think that's a good idea, but it broke CI. Not even this PR passed the CI.

Maybe you want to use --locked instead of --frozen

@kwonoj
Copy link
Contributor Author

kwonoj commented Jan 20, 2023

@sokra weird, --frozen is alias to --locked.

https://doc.rust-lang.org/cargo/commands/cargo-build.html#manifest-option

Also PR correctly passed ci. Ref: https://github.com/vercel/turbo/actions/runs/3963353615/jobs/6792718578

@kwonoj
Copy link
Contributor Author

kwonoj commented Jan 20, 2023

Looks like The --frozen flag also prevents Cargo from attempting to access the network to determine if it is out-of-date. is related, but --locked supposed to behave same. In any case, fine to revert and dig later.

@sokra
Copy link
Member

sokra commented Jan 20, 2023

hmm... weird...

This one didn't pass: https://github.com/vercel/turbo/actions/runs/3964721165/jobs/6793846772

@sokra
Copy link
Member

sokra commented Jan 20, 2023

It seem to complain about not being about to make network requests. I guess it need to make requests when it need to download the crates from the registry. Maybe it only passes with rust cache, but fails on downloading when there is no cache or crates are missing...

@sokra sokra mentioned this pull request Jan 20, 2023
Merged
kodiakhq bot pushed a commit that referenced this pull request Jan 21, 2023
@sokra
ci(actions): ensure cargo check with frozen lockfile (#3391)
8ae4e1d 
retry #3388 with `--locked` instead of `--frozen`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-olszewski chris-olszewski chris-olszewski approved these changes

@mehulkar mehulkar Awaiting requested review from mehulkar mehulkar is a code owner automatically assigned from vercel/turbo-oss

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwonoj @sokra @chris-olszewski