Factor out method to get resolved TaskDefinition #3378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
mehulkar
commented
Jan 19, 2023
| // defined in the Graph. Later, this will get Pipelines defined in the task's workspace as well. | ||
| func (g *CompleteGraph) getResolvedTaskDefinition(taskID string, taskName string) (*fs.TaskDefinition, error) { | ||
| return getTaskFromPipeline(g.Pipeline, taskID, taskName) | ||
| } |
There was a problem hiding this comment.
This is where we'll implement the magic in #2706
The way we resolve a taskDefinition will change once we start allowing workspaces to create their own config so it makes sense to factor this method out first.
f6b0c1c to
f15a498
Compare
nathanhammond
approved these changes
Jan 20, 2023
Let's chat about that, considering the other conversation we had today about pre-calculated task hashes as well. Want to make sure I'm not overlooking anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we resolve a taskDefinition will change
once we start allowing workspaces to create their own config so it makes sense to factor this method out first.