这是indexloc提供的服务，不要输入任何密码
Skip to content

better action cleanup #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 26, 2023
Merged

better action cleanup #3332

merged 4 commits into from
Jan 26, 2023

Conversation

ForsakenHarmony
Copy link
Contributor

No description provided.

@vercel

This comment was marked as off-topic.

Sign in to view
@ForsakenHarmony
Copy link
Contributor Author

ForsakenHarmony commented Jan 16, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ForsakenHarmony ForsakenHarmony marked this pull request as ready for review January 16, 2023 18:28
@ForsakenHarmony ForsakenHarmony requested review from a team as code owners January 16, 2023 18:28
@ForsakenHarmony ForsakenHarmony requested review from tknickman and NicholasLYang and removed request for tknickman and NicholasLYang January 16, 2023 18:28
@ForsakenHarmony ForsakenHarmony mentioned this pull request Jan 16, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/better-action-cleanup branch from c6b221f to fb81113 Compare January 17, 2023 14:05
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/better-action-cleanup branch from fb81113 to adcf601 Compare January 25, 2023 15:07
@github-actions

This comment was marked as off-topic.

Sign in to view
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/better-action-cleanup branch from adcf601 to 1cf26ca Compare January 25, 2023 15:42
@vercel vercel deleted a comment from github-actions bot Jan 25, 2023
@vercel vercel deleted a comment from github-actions bot Jan 25, 2023
@github-actions
Copy link
Contributor

Benchmark for ac0e481

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8941.96µs ± 40.13µs 8929.26µs ± 46.52µs -0.14%
bench_hmr_to_commit/Turbopack RCC/1000 modules 9268.99µs ± 69.57µs 9199.57µs ± 46.57µs -0.75%
bench_hmr_to_commit/Turbopack RSC/1000 modules 458.85ms ± 1.25ms 458.94ms ± 1.80ms +0.02%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8946.40µs ± 72.52µs 8953.21µs ± 70.12µs +0.08%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7890.98µs ± 68.40µs 7921.40µs ± 65.40µs +0.39%
bench_hmr_to_eval/Turbopack RCC/1000 modules 8037.57µs ± 50.01µs 8080.90µs ± 68.10µs +0.54%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7894.28µs ± 66.47µs 7982.52µs ± 70.19µs +1.12%
bench_hydration/Turbopack RCC/1000 modules 3345.04ms ± 11.23ms 3322.33ms ± 6.91ms -0.68%
bench_hydration/Turbopack RSC/1000 modules 2818.23ms ± 7.55ms 2796.51ms ± 10.07ms -0.77%
bench_hydration/Turbopack SSR/1000 modules 2637.49ms ± 9.16ms 2635.45ms ± 6.75ms -0.08%
bench_startup/Turbopack CSR/1000 modules 1644.21ms ± 2.63ms 1638.52ms ± 4.61ms -0.35%
bench_startup/Turbopack RCC/1000 modules 2173.12ms ± 8.65ms 2189.68ms ± 5.43ms +0.76%
bench_startup/Turbopack RSC/1000 modules 2075.10ms ± 4.85ms 2079.70ms ± 7.15ms +0.22%
bench_startup/Turbopack SSR/1000 modules 1765.22ms ± 5.49ms 1754.35ms ± 5.50ms -0.62%

@ForsakenHarmony ForsakenHarmony merged commit 4f36b44 into main Jan 26, 2023
@ForsakenHarmony ForsakenHarmony deleted the hrmny/better-action-cleanup branch January 26, 2023 13:52
NicholasLYang pushed a commit to NicholasLYang/turbo that referenced this pull request Jan 26, 2023
@ForsakenHarmony @NicholasLYang
better action cleanup (vercel#3332)
8560fa5
NicholasLYang pushed a commit to NicholasLYang/turbo that referenced this pull request Jan 26, 2023
@ForsakenHarmony @NicholasLYang
better action cleanup (vercel#3332)
76c7df6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@alexkirsz alexkirsz alexkirsz approved these changes

Assignees
No one assigned
Labels
area: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ForsakenHarmony @jridgewell @alexkirsz