fix(turborepo): Passing a relative path to --cwd when using --skip-infer. #3348
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
@NicholasLYang is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
What problem does this solve? I read through what this library does here: https://docs.rs/dunce/latest/dunce/#functions, but I'm not sure (based on PR title and diff) what --cwd input this addresses.
Are we trying to pass relative path? Or does this handle when a relative path is passed? In the case of the latter, does this deserve a dedicated prysk integration test?
|
@mehulkar more details here, we overlooked this one from this original fix: https://github.com/vercel/turbo/pull/3079/files |
|
@mehulkar yeah basically we need to pass absolute paths to Go and we're not currently doing that when we have the |
|
Curious, why this additional normalization isn't also in the |
|
It is, but in this case with |
Ran into this while testing changes. In general we should figure out better abstractions for relative and absolute paths in Rust.