Hoist DryRunSummary fields to PackageTask #3615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
38899ce to
385fc43
Compare
🟢 CI successful 🟢Thanks |
9b3c8ab to
a12ceea
Compare
The `PackageTask` abstraction has some statically analyzable information about the task, and DryRunSummary collects the rest. Hoisting as much of this information up to the PackageTask will make it easier to make it available on `RealRun`s without duplicating code. Ideally, DryRun doesn't do anything except print the information we already have.
a12ceea to
25c33c0
Compare
arlyon
reviewed
Feb 3, 2023
NicholasLYang
approved these changes
Feb 3, 2023
mehulkar
added a commit
that referenced
this pull request
Feb 3, 2023
The `PackageTask` abstraction has some statically analyzable information about the task, and DryRunSummary collects the rest. Hoisting as much of this information up to the PackageTask will make it easier to make it available on `RealRun`s without duplicating code. Ideally, DryRun doesn't do anything except print the information we already have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PackageTaskabstraction has some statically analyzable information about the task, and DryRunSummary collects the rest. Hoisting as much of this information up to the PackageTask will make it easier to make it available onRealRuns without duplicating code. Ideally, DryRun doesn't do anything except print the information we already have.This PR extracts some bits of #3431 without changing any behavior