这是indexloc提供的服务，不要输入任何密码
Skip to content

Do not submit a default --output-logs argument from Rust #3299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jan 13, 2023
Merged

Do not submit a default --output-logs argument from Rust #3299

merged 11 commits into from
Jan 13, 2023

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented Jan 12, 2023 •
edited
Loading

Specifying the CLI arg overrides outputMode from Task Definitions,
so we want to ensure that the user explicitly passes it, and not provide a default.

Fixes #3272

@vercel
Copy link

vercel bot commented Jan 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-designsystem-docs 🔄 Building (Inspect) Jan 13, 2023 at 1:37AM (UTC)
turbo-vite-web 🔄 Building (Inspect) Jan 13, 2023 at 1:37AM (UTC)
8 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 1:37AM (UTC)
examples-cra-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 1:37AM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 13, 2023 at 1:37AM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 1:37AM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 13, 2023 at 1:37AM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 1:37AM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 13, 2023 at 1:37AM (UTC)
turbo-site ⬜️ Ignored (Inspect) Visit Preview Jan 13, 2023 at 1:37AM (UTC)

@mehulkar
Do not submit a default --output-logs argument from Rust
0018d8b 
Specifying the CLI arg overrides outputMode from Task Definitions,
so we want to ensure that the user explicitly passes it, and not provide a default.

Fixes #3272
@mehulkar mehulkar force-pushed the mehulkar/turbo-688-replays-task-output-even-with-outputmode branch from 0b71859 to 0018d8b Compare January 12, 2023 22:04
@mehulkar mehulkar changed the title Use turbo to build turbo Do not submit a default --output-logs argument from Rust Jan 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

chris-olszewski
chris-olszewski approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehulkar mehulkar marked this pull request as ready for review January 12, 2023 22:50
@mehulkar mehulkar requested a review from a team as a code owner January 12, 2023 22:50
@mehulkar
Copy link
Contributor Author

mehulkar commented Jan 13, 2023 •
edited
Loading

installing sponge is failing on some of the test runs

@github-actions
Copy link
Contributor

Benchmark for 30c787e

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 1644.63ms ± 5.87ms 1608.30ms ± 5.55ms -2.21% -0.83%
bench_startup/Turbopack SSR/1000 modules 2058.60ms ± 5.60ms 2028.47ms ± 5.07ms -1.46% -0.43%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8020.01µs ± 52.08µs 7993.99µs ± 57.26µs -0.32%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8351.30µs ± 59.94µs 8275.71µs ± 36.67µs -0.91%
bench_hmr_to_commit/Turbopack RSC/1000 modules 461.16ms ± 1.53ms 458.34ms ± 2.95ms -0.61%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8147.99µs ± 45.30µs 8163.33µs ± 48.59µs +0.19%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7101.27µs ± 35.34µs 7064.66µs ± 40.32µs -0.52%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7201.85µs ± 32.23µs 7268.96µs ± 65.47µs +0.93%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7167.68µs ± 69.08µs 7274.87µs ± 30.04µs +1.50%
bench_hydration/Turbopack RCC/1000 modules 3354.40ms ± 12.16ms 3367.37ms ± 13.18ms +0.39%
bench_hydration/Turbopack RSC/1000 modules 2903.65ms ± 9.69ms 2886.84ms ± 15.20ms -0.58%
bench_hydration/Turbopack SSR/1000 modules 2699.36ms ± 17.31ms 2649.56ms ± 17.30ms -1.84%
bench_startup/Turbopack CSR/1000 modules 1644.63ms ± 5.87ms 1608.30ms ± 5.55ms -2.21% -0.83%
bench_startup/Turbopack RCC/1000 modules 2492.48ms ± 4.49ms 2508.79ms ± 8.74ms +0.65%
bench_startup/Turbopack RSC/1000 modules 2398.08ms ± 7.64ms 2415.53ms ± 9.48ms +0.73%
bench_startup/Turbopack SSR/1000 modules 2058.60ms ± 5.60ms 2028.47ms ± 5.07ms -1.46% -0.43%

@mehulkar mehulkar merged commit 4f78822 into main Jan 13, 2023
@mehulkar mehulkar deleted the mehulkar/turbo-688-replays-task-output-even-with-outputmode branch January 13, 2023 04:31
kdy1 pushed a commit to kdy1/turbo that referenced this pull request Jan 13, 2023
@mehulkar @kdy1
Do not submit a default --output-logs argument from Rust (vercel#3299)
4637785 
Specifying the CLI arg overrides outputMode from Task Definitions,
so we want to ensure that the user explicitly passes it, and not provide
a default.

Fixes vercel#3272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-olszewski chris-olszewski chris-olszewski approved these changes

@nathanhammond nathanhammond Awaiting requested review from nathanhammond nathanhammond is a code owner automatically assigned from vercel/turbo-oss

@arlyon arlyon Awaiting requested review from arlyon arlyon is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[turborepo] replays task output even with "outputMode": "new-only"
2 participants
@mehulkar @chris-olszewski