Fix deduplication when importing module statically and dynamically #3297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `processed_assets` `IndexSet` was performing deduplication on the `AssetVc`, which is the same between static (`import ... from "foo"`) and dynamic (`import("foo")`) imports of the same specifier. But, the _reference_ to those assets is different, and generates different chunking semantics. In order for both to succeed, we need to process both assets.
Coupled with #3193's ability to load chunks on the server side, this fixes fixes WEB-381.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
Benchmark for 3ac5c11Click to view benchmark
|
Benchmark for d703658
Click to view full benchmark
|
Benchmark for 05958a2Click to view benchmark
|
Benchmark for 435d428Click to view benchmark
|
Benchmark for 4d29b37Click to view benchmark
|
sokra
approved these changes
Jan 13, 2023
| @@ -407,7 +409,7 @@ async fn chunk_content_internal<I: FromChunkableAsset>( | |||
| for asset in assets | |||
| .await? | |||
| .iter() | |||
| .filter(|asset| processed_assets.insert(**asset)) | |||
| .filter(|asset| processed_assets.insert((chunking_type, **asset))) | |||
There was a problem hiding this comment.
This causes Placed and PlacedOrParallel to generate two chunk items.
Can we add a processed_assets.insert((Placed, **asset)) into the placed code path in PlacedOrParallel and a processed_assets.insert((Parallel, **asset)) into the parallel code path.
This was referenced Jan 20, 2023
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
…ercel/turborepo#3297) The `processed_assets` `IndexSet` was performing deduplication on the `AssetVc`, which is the same between static (`import ... from "foo"`) and dynamic (`import("foo")`) imports of the same specifier. But, the _reference_ to those assets is different, and generates different chunking semantics. In order for both to succeed, we need to process both assets. Coupled with vercel/turborepo#3193's ability to load chunks on the server side, this fixes fixes WEB-381.
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
…ercel/turborepo#3297) The `processed_assets` `IndexSet` was performing deduplication on the `AssetVc`, which is the same between static (`import ... from "foo"`) and dynamic (`import("foo")`) imports of the same specifier. But, the _reference_ to those assets is different, and generates different chunking semantics. In order for both to succeed, we need to process both assets. Coupled with vercel/turborepo#3193's ability to load chunks on the server side, this fixes fixes WEB-381.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…ercel/turborepo#3297) The `processed_assets` `IndexSet` was performing deduplication on the `AssetVc`, which is the same between static (`import ... from "foo"`) and dynamic (`import("foo")`) imports of the same specifier. But, the _reference_ to those assets is different, and generates different chunking semantics. In order for both to succeed, we need to process both assets. Coupled with #3193's ability to load chunks on the server side, this fixes fixes WEB-381.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…ercel/turborepo#3297) The `processed_assets` `IndexSet` was performing deduplication on the `AssetVc`, which is the same between static (`import ... from "foo"`) and dynamic (`import("foo")`) imports of the same specifier. But, the _reference_ to those assets is different, and generates different chunking semantics. In order for both to succeed, we need to process both assets. Coupled with #3193's ability to load chunks on the server side, this fixes fixes WEB-381.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…ercel/turborepo#3297) The `processed_assets` `IndexSet` was performing deduplication on the `AssetVc`, which is the same between static (`import ... from "foo"`) and dynamic (`import("foo")`) imports of the same specifier. But, the _reference_ to those assets is different, and generates different chunking semantics. In order for both to succeed, we need to process both assets. Coupled with #3193's ability to load chunks on the server side, this fixes fixes WEB-381.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
processed_assetsIndexSetwas performing deduplication on theAssetVc, which is the same between static (import ... from "foo") and dynamic (import("foo")) imports of the same specifier. But, the reference to those assets is different, and generates different chunking semantics. In order for both to succeed, we need to process both assets.Coupled with #3193's ability to load chunks on the server side, this fixes fixes WEB-381.