这是indexloc提供的服务，不要输入任何密码
Skip to content

add cargo-sweep action #3265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 16, 2023
Merged

add cargo-sweep action #3265

merged 4 commits into from
Jan 16, 2023

Conversation

ForsakenHarmony
Copy link
Contributor

@ForsakenHarmony ForsakenHarmony commented Jan 11, 2023 •
edited
Loading

This should clean up old build artifacts

@vercel
Copy link

vercel bot commented Jan 11, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-cra-web 🔄 Building (Inspect) Jan 16, 2023 at 4:00PM (UTC)
examples-native-web 🔄 Building (Inspect) Jan 16, 2023 at 4:00PM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 16, 2023 at 4:00PM (UTC)
7 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Jan 16, 2023 at 4:00PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Jan 16, 2023 at 4:00PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jan 16, 2023 at 4:00PM (UTC)
examples-nonmonorepo ⬜️ Ignored (Inspect) Jan 16, 2023 at 4:00PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Jan 16, 2023 at 4:00PM (UTC)
examples-tailwind-web ⬜️ Ignored (Inspect) Jan 16, 2023 at 4:00PM (UTC)
turbo-vite-web ⬜️ Ignored (Inspect) Jan 16, 2023 at 4:00PM (UTC)

@ForsakenHarmony
Copy link
Contributor Author

ForsakenHarmony commented Jan 11, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/cargo-sweep-action branch from bdbd3d7 to c473ece Compare January 11, 2023 16:54
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/cargo-sweep-action branch from c473ece to e88f4bd Compare January 11, 2023 16:58
@github-actions
Copy link
Contributor

Benchmark for 20e090b

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8941.09µs ± 58.06µs 8946.68µs ± 56.98µs +0.06%
bench_hmr_to_commit/Turbopack RCC/1000 modules 9163.83µs ± 56.31µs 9184.84µs ± 61.18µs +0.23%
bench_hmr_to_commit/Turbopack RSC/1000 modules 485.57ms ± 1.25ms 481.41ms ± 2.99ms -0.86%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8996.56µs ± 54.23µs 9033.11µs ± 66.91µs +0.41%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7885.98µs ± 62.57µs 7878.48µs ± 94.39µs -0.10%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7913.37µs ± 56.40µs 7959.99µs ± 35.63µs +0.59%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7994.34µs ± 95.42µs 7908.59µs ± 59.83µs -1.07%
bench_hydration/Turbopack RCC/1000 modules 3432.91ms ± 7.14ms 3413.48ms ± 7.57ms -0.57%
bench_hydration/Turbopack RSC/1000 modules 2896.52ms ± 10.01ms 2909.66ms ± 12.49ms +0.45%
bench_hydration/Turbopack SSR/1000 modules 2706.22ms ± 9.41ms 2734.49ms ± 11.62ms +1.04%
bench_startup/Turbopack CSR/1000 modules 1710.97ms ± 3.58ms 1695.41ms ± 5.24ms -0.91%
bench_startup/Turbopack RCC/1000 modules 2582.18ms ± 10.93ms 2571.51ms ± 7.95ms -0.41%
bench_startup/Turbopack RSC/1000 modules 2482.37ms ± 5.44ms 2467.42ms ± 6.03ms -0.60%
bench_startup/Turbopack SSR/1000 modules 2108.27ms ± 5.31ms 2132.53ms ± 7.51ms +1.15%

@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/cargo-sweep-action branch from a033768 to 0be63cb Compare January 11, 2023 18:45
@github-actions
Copy link
Contributor

Benchmark for fcf1986

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8715.29µs ± 58.40µs 8756.97µs ± 48.21µs +0.48%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8922.27µs ± 65.33µs 8989.50µs ± 63.46µs +0.75%
bench_hmr_to_commit/Turbopack RSC/1000 modules 478.02ms ± 1.32ms 478.81ms ± 1.27ms +0.17%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8809.48µs ± 46.35µs 8702.94µs ± 82.85µs -1.21%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7691.62µs ± 31.48µs 7743.17µs ± 55.87µs +0.67%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7808.91µs ± 63.54µs 7883.30µs ± 58.20µs +0.95%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7836.52µs ± 25.01µs 7735.05µs ± 42.18µs -1.29%
bench_hydration/Turbopack RCC/1000 modules 3363.25ms ± 10.93ms 3361.92ms ± 10.32ms -0.04%
bench_hydration/Turbopack RSC/1000 modules 2843.74ms ± 7.87ms 2841.63ms ± 10.95ms -0.07%
bench_hydration/Turbopack SSR/1000 modules 2669.27ms ± 10.48ms 2660.94ms ± 8.87ms -0.31%
bench_startup/Turbopack CSR/1000 modules 1653.98ms ± 4.70ms 1645.11ms ± 5.72ms -0.54%
bench_startup/Turbopack RCC/1000 modules 2545.63ms ± 6.79ms 2526.31ms ± 7.69ms -0.76%
bench_startup/Turbopack RSC/1000 modules 2423.77ms ± 13.85ms 2414.96ms ± 6.38ms -0.36%
bench_startup/Turbopack SSR/1000 modules 2063.07ms ± 4.64ms 2071.21ms ± 6.99ms +0.39%

@ForsakenHarmony ForsakenHarmony mentioned this pull request Jan 12, 2023
Closed
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/cargo-sweep-action branch from 0be63cb to 7baa4d4 Compare January 12, 2023 18:20
@ForsakenHarmony ForsakenHarmony marked this pull request as ready for review January 12, 2023 18:20
@ForsakenHarmony ForsakenHarmony requested review from a team as code owners January 12, 2023 18:20
@github-actions
Copy link
Contributor

Benchmark for d5f0609

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8394.64µs ± 68.75µs 8405.24µs ± 59.75µs +0.13%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8661.97µs ± 49.48µs 8651.99µs ± 82.27µs -0.12%
bench_hmr_to_commit/Turbopack RSC/1000 modules 480.06ms ± 1.65ms 475.93ms ± 2.43ms -0.86%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8487.49µs ± 32.47µs 8493.16µs ± 48.99µs +0.07%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7499.44µs ± 45.19µs 7382.62µs ± 51.44µs -1.56%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7540.54µs ± 59.00µs 7506.64µs ± 43.96µs -0.45%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7536.07µs ± 69.86µs 7439.76µs ± 54.19µs -1.28%
bench_hydration/Turbopack RCC/1000 modules 3363.67ms ± 12.07ms 3361.16ms ± 10.34ms -0.07%
bench_hydration/Turbopack RSC/1000 modules 2870.66ms ± 12.07ms 2852.09ms ± 7.60ms -0.65%
bench_hydration/Turbopack SSR/1000 modules 2657.91ms ± 10.83ms 2661.39ms ± 10.34ms +0.13%
bench_startup/Turbopack CSR/1000 modules 1662.20ms ± 5.04ms 1640.86ms ± 5.71ms -1.28%
bench_startup/Turbopack RCC/1000 modules 2504.59ms ± 10.65ms 2505.89ms ± 8.61ms +0.05%
bench_startup/Turbopack RSC/1000 modules 2403.89ms ± 8.67ms 2394.91ms ± 9.15ms -0.37%
bench_startup/Turbopack SSR/1000 modules 2047.03ms ± 3.60ms 2039.89ms ± 7.74ms -0.35%

alexkirsz
alexkirsz reviewed Jan 13, 2023
View reviewed changes
@ForsakenHarmony ForsakenHarmony force-pushed the hrmny/cargo-sweep-action branch from 7baa4d4 to b88f775 Compare January 16, 2023 15:59
@github-actions
Copy link
Contributor

Benchmark for 80b0caa

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack RSC/1000 modules 472.83ms ± 2.18ms 479.96ms ± 1.02ms +1.51% +0.15%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 8673.01µs ± 78.15µs 8751.89µs ± 44.87µs +0.91%
bench_hmr_to_commit/Turbopack RCC/1000 modules 8964.90µs ± 42.56µs 8985.84µs ± 63.54µs +0.23%
bench_hmr_to_commit/Turbopack RSC/1000 modules 472.83ms ± 2.18ms 479.96ms ± 1.02ms +1.51% +0.15%
bench_hmr_to_commit/Turbopack SSR/1000 modules 8786.50µs ± 74.87µs 8772.95µs ± 86.98µs -0.15%
bench_hmr_to_eval/Turbopack CSR/1000 modules 7749.04µs ± 58.13µs 7753.36µs ± 61.88µs +0.06%
bench_hmr_to_eval/Turbopack RCC/1000 modules 7894.89µs ± 48.13µs 7771.85µs ± 65.63µs -1.56%
bench_hmr_to_eval/Turbopack SSR/1000 modules 7759.74µs ± 33.16µs 7759.44µs ± 64.27µs -0.00%
bench_hydration/Turbopack RCC/1000 modules 3405.44ms ± 10.00ms 3406.18ms ± 9.26ms +0.02%
bench_hydration/Turbopack RSC/1000 modules 2905.08ms ± 6.45ms 2898.53ms ± 10.90ms -0.23%
bench_hydration/Turbopack SSR/1000 modules 2692.46ms ± 9.51ms 2701.68ms ± 9.85ms +0.34%
bench_startup/Turbopack CSR/1000 modules 1673.40ms ± 3.02ms 1676.04ms ± 4.19ms +0.16%
bench_startup/Turbopack RCC/1000 modules 2556.68ms ± 6.48ms 2534.49ms ± 7.87ms -0.87%
bench_startup/Turbopack RSC/1000 modules 2437.15ms ± 7.55ms 2448.20ms ± 5.25ms +0.45%
bench_startup/Turbopack SSR/1000 modules 2081.69ms ± 5.29ms 2077.02ms ± 5.36ms -0.22%

@ForsakenHarmony ForsakenHarmony merged commit 04cccd7 into main Jan 16, 2023
@ForsakenHarmony ForsakenHarmony deleted the hrmny/cargo-sweep-action branch January 16, 2023 17:16
NicholasLYang pushed a commit to NicholasLYang/turbo that referenced this pull request Jan 18, 2023
@ForsakenHarmony @NicholasLYang
add cargo-sweep action (vercel#3265)
0bcefb5 
This should clean up old build artifacts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkirsz alexkirsz alexkirsz approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ForsakenHarmony @alexkirsz