fix: use error logger in Rust turborepo #3253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chris-olszewski is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
tknickman
approved these changes
Jan 10, 2023
mehulkar
approved these changes
Jan 10, 2023
stderr |
…676-audit-shim-log-usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves messaging in Rust land to use the standard logger where applicable:
turborepo_lib::mainnow logs any errors via the error logger instead of having the caller decide how to handle the errorThe following are other uses of standard (
println!/write!) print functionality that weren't changed:turbo --versionturbo binThis PR does not change the Go side of error logging, but there should only be a single place that needs updating: root.go
Example of new output:
