这是indexloc提供的服务，不要输入任何密码
Skip to content

Update monorepo handbook for tsc task #2911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update monorepo handbook for tsc task #2911

wants to merge 3 commits into from

Conversation

@rubber-duck-software
Copy link

@rubber-duck-software rubber-duck-software commented Dec 2, 2022

Update the "Running tasks" section for the typescript page of the monorepo handbook to address the subtleties discussed in #2855

@rubber-duck-software rubber-duck-software requested a review from a team as a code owner December 2, 2022 18:06
@vercel
Copy link
Contributor

vercel bot commented Dec 2, 2022

@rubber-duck-software is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link
Contributor

vercel bot commented Dec 2, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 8:34PM (UTC)
examples-cra-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 8:34PM (UTC)
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 8:34PM (UTC)
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 8:34PM (UTC)
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 8:34PM (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 8:34PM (UTC)
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 8:34PM (UTC)
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 8:34PM (UTC)
turbo-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 8:34PM (UTC)

@github-actions github-actions bot added the area: docs Improvements or additions to documentation label Dec 2, 2022
@weyert
Copy link
Contributor

weyert commented Dec 20, 2022

I tried this with turbo@canary (1.7.0-canary.4) but this is not working. I am getting an error:

 ERROR  run failed: error preparing engine: Missing task definition, configure "topo" or "___ROOT___#topo" in turbo.json

@rubber-duck-software rubber-duck-software mentioned this pull request Dec 28, 2022
Closed
@rubber-duck-software
Copy link
Author

rubber-duck-software commented Dec 29, 2022

Hey @weyert , can you provide more context on this failure? Here is an example repo where this configuration is working https://github.com/rubber-duck-software/turborepo-caching-demo.

@connorjs
Copy link

connorjs commented Mar 9, 2023

This (at least partially) relates to a new discussion I opened (#4143). Interested in hearing your thoughts @rubber-duck-software. (And thanks for the chatter on these tsc issues.)

@anthonyshew
Copy link
Contributor

anthonyshew commented Jun 26, 2023

We ended up adding documenting this in the Running Tasks section!

Going to close so we can have one canonical place where this information is found. Definitely appreciate the effort in writing this PR, @rubber-duck-software, and helping us to learn how to convey this in the documentation through the conversation here and in #2855.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nathanhammond nathanhammond Awaiting requested review from nathanhammond nathanhammond is a code owner automatically assigned from vercel/turbo-oss

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski chris-olszewski is a code owner automatically assigned from vercel/turbo-oss

Assignees

No one assigned

Labels

area: docs Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rubber-duck-software @weyert @connorjs @anthonyshew