Optimize {run_add_to,run_remove_from}_scope_queue #2423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
alexkirsz
commented
Oct 27, 2022
| let schedule_self = | ||
| self.add_self_to_new_scope(&mut state, id, backend, turbo_tasks); | ||
| drop(state); | ||
| queue.extend(children.iter().copied().map(|child| (child, depth + 1))); |
There was a problem hiding this comment.
This line is the actual change.
| ); | ||
| }); | ||
| if queue.len() > SPLIT_OFF_QUEUE_AT { | ||
| let split_off_queue = queue.split_off(SPLIT_OFF_QUEUE_AT); |
There was a problem hiding this comment.
This logic is now much simpler.
| @@ -859,17 +860,11 @@ impl Task { | |||
| TaskScopes::Inner(ref mut set, _) => { | |||
| if set.remove(id) { | |||
| self.remove_self_from_scope(&mut state, id, backend, turbo_tasks); | |||
| let children = state.children.iter().copied().collect::<Vec<_>>(); | |||
| queue.extend(state.children.iter().copied()); | |||
There was a problem hiding this comment.
This line is the actual change.
ForsakenHarmony
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
add_to_scope_internal_shallow/remove_from_scope_internal_shallowThis shows improvements up to ~6% on a 5000 modules SSR benchmark:
On 20k modules, there are no significant changes.