这是indexloc提供的服务，不要输入任何密码
Skip to content

Add turbopack team to CODEOWNERS #2420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2022
Merged

Add turbopack team to CODEOWNERS #2420

merged 2 commits into from
Oct 27, 2022

Conversation

mehulkar
Copy link
Contributor

No description provided.

@mehulkar mehulkar requested a review from a team as a code owner October 27, 2022 18:41
@vercel
Copy link

vercel bot commented Oct 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Oct 27, 2022 at 10:19PM (UTC)
5 Ignored Deployments
Name Status Preview Comments Updated
examples-basic-web ⬜️ Ignored (Inspect) Oct 27, 2022 at 10:19PM (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Oct 27, 2022 at 10:19PM (UTC)
examples-kitchensink-blog ⬜️ Ignored (Inspect) Oct 27, 2022 at 10:19PM (UTC)
examples-native-web ⬜️ Ignored (Inspect) Oct 27, 2022 at 10:19PM (UTC)
examples-svelte-web ⬜️ Ignored (Inspect) Oct 27, 2022 at 10:19PM (UTC)

@mehulkar mehulkar changed the title Update CODEOWNERS Add turbopack team to CODEOWNERS Oct 27, 2022
@mehulkar mehulkar merged commit 19a4f78 into main Oct 27, 2022
@mehulkar mehulkar deleted the mehulkar-patch-1 branch October 27, 2022 22:23
ForsakenHarmony
ForsakenHarmony reviewed Oct 27, 2022
View reviewed changes
.github/CODEOWNERS
/Cargo.lock
/Cargo.toml
/rust-toolchain
/pnpm-lock.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just leave that as nothing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey just saw this comment! What do you mean leave that as nothing? As in, nobody owns it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the lock file could be changed because of something in the docs or something in the crates folder, so I feel like it alone shouldn't assign anyone 🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. (1) I didn't realize that leaving it empty would assign no one (that's cool if true!), but (2) the way it's structured now is that all files are co-owned by both teams unless specified otherwise. If we left it blank and no-one is assigned, would the PR author pick people to ✅ manually? I think we'd still need approvers, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony left review comments

@jridgewell jridgewell jridgewell approved these changes

@sokra sokra sokra approved these changes

@padmaia padmaia padmaia approved these changes

@nathanhammond nathanhammond Awaiting requested review from nathanhammond nathanhammond is a code owner automatically assigned from vercel/turbo-oss

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

@jaredpalmer jaredpalmer Awaiting requested review from jaredpalmer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mehulkar @jridgewell @sokra @padmaia @ForsakenHarmony