Source map tracing fixes #2402
Merged
Source map tracing fixes #2402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jridgewell is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
e432f90 to
969ee43
Compare
alexkirsz
approved these changes
Oct 27, 2022
If the input file was pre-transformed (eg, a file in `node_modules`), then we would find that input source map. Those don't have the hash fingerprint, and stripping it would panic.
This removes the `[disk-fs-name]` portion of the source path, so that traced error stacks point directly at the file. It also means the console log paths are clickable!
969ee43 to
de29cd4
Compare
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes:
pathinstead of the foundfile.[disk-fs-name]part of traced filenamesevery frame (and I'm assuming a lot of those frames share a source)
sourcemapcrate that returned a token on a previous lineSourceAssetVcholding a input's pre-transpiled source map, which doesn't contain a fingerprintMutexwrapper for tracing source maps, since they aren't mutable.There's still some more optimizations that we can do, specifically to avoid round trip serialize->deserialize for tracing that I'm working on. I just couldn't finish that tonight.