Avoid recomputing all_assets_map on every change #2464

alexkirsz · 2022-10-28T19:03:01Z

No description provided.

vercel · 2022-10-28T19:03:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Ignored Deployments

Name	Status	Preview	Updated
examples-basic-web	⬜️ Ignored (Inspect)		Oct 28, 2022 at 7:54PM (UTC)
examples-designsystem-docs	⬜️ Ignored (Inspect)		Oct 28, 2022 at 7:54PM (UTC)
examples-kitchensink-blog	⬜️ Ignored (Inspect)		Oct 28, 2022 at 7:54PM (UTC)
examples-native-web	⬜️ Ignored (Inspect)		Oct 28, 2022 at 7:54PM (UTC)
examples-svelte-web	⬜️ Ignored (Inspect)		Oct 28, 2022 at 7:54PM (UTC)
turbo-site	⬜️ Ignored (Inspect)	Visit Preview	Oct 28, 2022 at 7:54PM (UTC)

jridgewell

This'll break https://github.com/vercel/turbo/blob/b3fad7d1ce2514953ebed198b2217a2c833dc976/crates/next-core/src/nodejs/mod.rs#L407-L416, https://github.com/vercel/turbo/blob/b3fad7d1ce2514953ebed198b2217a2c833dc976/crates/next-core/src/source_map/content_source.rs#L92-L95, and https://github.com/vercel/turbo/blob/b3fad7d1ce2514953ebed198b2217a2c833dc976/crates/turbopack-tests/tests/snapshot.rs#L258-L263 until #2426 is merged.

jridgewell · 2022-10-28T19:07:22Z

crates/turbopack-ecmascript/src/chunk/source_map.rs

@@ -131,7 +135,7 @@ impl AssetReference for EcmascriptChunkSourceMapAssetReference {
                    EcmascriptChunkEntrySourceMapAsset {
                        chunk_path: path,
                        code: item.code_vc,
-                        hash: item.hash,
+                        id: item.chunk_item.id(),


If the item.hash is already computed, why can't we just use it instead?

Will that force a new EcmascriptChunkEntrySourceMapAssetVc every time the hash changes?

See followup PR.

Will fix in followup

jaredpalmer · 2022-10-28T20:24:11Z

We merging?

In order to serve sourcemaps with HMR updates, we (used to) reference a source map asset for every chunk item using the items version hash (see #2464 and #2474 for the headaches this can cause). This update changes that, so that a chunk becomes responsible for giving access to one of its item's source map. We already have the `GenerateSourceMap` trait which assembles the chunk's `Sectioned` sourcemap from all chunk items, so why not just allow access to an individual section? Coupled with a `ContentSource` that can retrieve the chunk, we can then provide access to that chunk's current item sourcemaps per request.

In order to serve source maps with HMR updates, we (used to) reference a source map asset for every chunk item using the items version hash (see #2464 and #2474 for the headaches this can cause). This update changes that, so that a chunk becomes responsible for giving access to one of its item's source map. We already have the `GenerateSourceMap` trait which assembles the chunk's `Sectioned` source map from all chunk items, so why not just allow access to an individual section? Coupled with a `ContentSource` that can retrieve the chunk, we can then provide access to that chunk's current item source maps per request.

…3059) In order to serve source maps with HMR updates, we (used to) reference a source map asset for every chunk item using the items version hash (see vercel/turborepo#2464 and vercel/turborepo#2474 for the headaches this can cause). This update changes that, so that a chunk becomes responsible for giving access to one of its item's source map. We already have the `GenerateSourceMap` trait which assembles the chunk's `Sectioned` source map from all chunk items, so why not just allow access to an individual section? Coupled with a `ContentSource` that can retrieve the chunk, we can then provide access to that chunk's current item source maps per request.

* Avoid recomputing all_assets_map on every change * fix snapshot test and update snapshot Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>

…3059) In order to serve source maps with HMR updates, we (used to) reference a source map asset for every chunk item using the items version hash (see vercel/turborepo#2464 and vercel/turborepo#2474 for the headaches this can cause). This update changes that, so that a chunk becomes responsible for giving access to one of its item's source map. We already have the `GenerateSourceMap` trait which assembles the chunk's `Sectioned` source map from all chunk items, so why not just allow access to an individual section? Coupled with a `ContentSource` that can retrieve the chunk, we can then provide access to that chunk's current item source maps per request.

* Avoid recomputing all_assets_map on every change * fix snapshot test and update snapshot Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>

…3059) In order to serve source maps with HMR updates, we (used to) reference a source map asset for every chunk item using the items version hash (see vercel/turborepo#2464 and vercel/turborepo#2474 for the headaches this can cause). This update changes that, so that a chunk becomes responsible for giving access to one of its item's source map. We already have the `GenerateSourceMap` trait which assembles the chunk's `Sectioned` source map from all chunk items, so why not just allow access to an individual section? Coupled with a `ContentSource` that can retrieve the chunk, we can then provide access to that chunk's current item source maps per request.

Avoid recomputing all_assets_map on every change

0619e7f

alexkirsz requested a review from sokra October 28, 2022 19:03

alexkirsz requested a review from a team as a code owner October 28, 2022 19:03

vercel bot deployed to Preview – turbo-site October 28, 2022 19:04 View deployment

sokra approved these changes Oct 28, 2022

View reviewed changes

alexkirsz added the pr: automerge Kodiak will merge these automatically after checks pass label Oct 28, 2022

jridgewell previously requested changes Oct 28, 2022

View reviewed changes

fix snapshot test and update snapshot

e33b6da

jridgewell added the area: turbopack label Oct 28, 2022

jridgewell approved these changes Oct 28, 2022

View reviewed changes

sokra merged commit 8902eeb into main Oct 28, 2022

sokra deleted the alexkirsz/sourcemap-ref-perf branch October 28, 2022 20:27

jridgewell mentioned this pull request Dec 17, 2022

Remove chunk item source maps from the asset graph #3059

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Avoid recomputing all_assets_map on every change #2464

Avoid recomputing all_assets_map on every change #2464

Uh oh!

alexkirsz commented Oct 28, 2022

Uh oh!

vercel bot commented Oct 28, 2022 •

edited

Loading

Uh oh!

jridgewell left a comment •

edited

Loading

Uh oh!

jridgewell Oct 28, 2022

Uh oh!

sokra Oct 28, 2022

Uh oh!

jaredpalmer commented Oct 28, 2022

Uh oh!

Uh oh!

Avoid recomputing all_assets_map on every change #2464

Avoid recomputing all_assets_map on every change #2464

Uh oh!

Conversation

alexkirsz commented Oct 28, 2022

Uh oh!

vercel bot commented Oct 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jridgewell left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jridgewell Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

sokra Oct 28, 2022

Choose a reason for hiding this comment

Uh oh!

jaredpalmer commented Oct 28, 2022

Uh oh!

Uh oh!

vercel bot commented Oct 28, 2022 •

edited

Loading

jridgewell left a comment •

edited

Loading