Speed up NoMoveVec allocations
#2398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sokra
approved these changes
Oct 27, 2022
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
This speeds up `NoMoveVec` allocations by ensuring that new bucket initialization is just as fast as `calloc`. Before, we would initialize everything as `Option<T>::None`, which is not guaranteed to match a zeroed value because of niche optimization[1]. This comes at the cost of slightly higher memory usage, but that should be more than offset by vercel/turborepo#2395. [1] https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=e60c0bfa4d32a3609fd39299a1c79c29
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
This speeds up `NoMoveVec` allocations by ensuring that new bucket initialization is just as fast as `calloc`. Before, we would initialize everything as `Option<T>::None`, which is not guaranteed to match a zeroed value because of niche optimization[1]. This comes at the cost of slightly higher memory usage, but that should be more than offset by vercel/turborepo#2395. [1] https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=e60c0bfa4d32a3609fd39299a1c79c29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up
NoMoveVecallocations by ensuring that new bucket initialization is just as fast ascalloc. Before, we would initialize everything asOption<T>::None, which is not guaranteed to match a zeroed value because of niche optimization[1]. This comes at the cost of slightly higher memory usage, but that should be more than offset by #2395.[1] https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=e60c0bfa4d32a3609fd39299a1c79c29