Warn on not-yet-supported import.meta usage #2397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Ignored Deployments
|
4e21634 to
ae2c251
Compare
sokra
approved these changes
Oct 27, 2022
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
This implements a warning when `import.meta` is referenced, both as a standalone expression (`import.meta`) and as a member expression (`import.meta.url`, `import.meta.foo`, etc.).
To do:
* [x] This expression covers both `import.meta` as well as `new.target`. Investigate how this usage is impacted and handle it.
Test Plan:
* Added a `import.meta` expression and `import.meta.url` member expression in a test app and verified both were flagged (see below)
* In the same test app, verified using `new.target` was not flagged.
```
path/to/testapp/src/index.jsx:1:12 error TP1106 import.meta is not yet supported
1 > console.log(import.meta);
2 console.log(import.meta.url);
3
4 function Foo() {
5 new.target;
path/to/testapp/src/index.jsx:2:12 error TP1106 import.meta is not yet supported
1 console.log(import.meta);
2 > console.log(import.meta.url);
3
4 function Foo() {
5 new.target;
6 }
```
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
This implements a warning when `import.meta` is referenced, both as a standalone expression (`import.meta`) and as a member expression (`import.meta.url`, `import.meta.foo`, etc.).
To do:
* [x] This expression covers both `import.meta` as well as `new.target`. Investigate how this usage is impacted and handle it.
Test Plan:
* Added a `import.meta` expression and `import.meta.url` member expression in a test app and verified both were flagged (see below)
* In the same test app, verified using `new.target` was not flagged.
```
path/to/testapp/src/index.jsx:1:12 error TP1106 import.meta is not yet supported
1 > console.log(import.meta);
2 console.log(import.meta.url);
3
4 function Foo() {
5 new.target;
path/to/testapp/src/index.jsx:2:12 error TP1106 import.meta is not yet supported
1 console.log(import.meta);
2 > console.log(import.meta.url);
3
4 function Foo() {
5 new.target;
6 }
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a warning when
import.metais referenced, both as a standalone expression (import.meta) and as a member expression (import.meta.url,import.meta.foo, etc.).To do:
import.metaas well asnew.target. Investigate how this usage is impacted and handle it.Test Plan:
import.metaexpression andimport.meta.urlmember expression in a test app and verified both were flagged (see below)new.targetwas not flagged.