这是indexloc提供的服务，不要输入任何密码
Skip to content

benchmark update contrast #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2022
Merged

benchmark update contrast #2393

merged 2 commits into from
Oct 27, 2022

Conversation

gaspar09
Copy link
Contributor

No description provided.

@gaspar09 gaspar09 requested a review from a team as a code owner October 26, 2022 23:45
@vercel
Copy link

vercel bot commented Oct 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
examples-basic-web ✅ Ready (Inspect) Visit Preview Oct 27, 2022 at 0:46AM (UTC)
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview Oct 27, 2022 at 0:46AM (UTC)
examples-native-web ✅ Ready (Inspect) Visit Preview Oct 27, 2022 at 0:46AM (UTC)
examples-svelte-web 🔄 Building (Inspect) Oct 27, 2022 at 0:46AM (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Oct 27, 2022 at 0:46AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
examples-designsystem-docs ⬜️ Ignored (Inspect) Oct 27, 2022 at 0:46AM (UTC)

mehulkar
mehulkar approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@mehulkar mehulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colors look great! Another AX improvement here might be to wrap the whole benchmarks component in a figure element and add figcaption

@gaspar09 gaspar09 added the pr: automerge Kodiak will merge these automatically after checks pass label Oct 27, 2022
@kodiakhq kodiakhq bot merged commit 4a60a8b into main Oct 27, 2022
@kodiakhq kodiakhq bot deleted the gaspar/turbo-393-increase-bar-contrast-ghost-bar-contrast branch October 27, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehulkar mehulkar mehulkar approved these changes

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaspar09 @mehulkar @jridgewell