feat: add shim to help and version integration tests #2386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chris-olszewski is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
NicholasLYang
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
All these seem good, although I'm basically doing the rust version of these tests in #2379.
| @@ -73,3 +73,84 @@ Test help flag | |||
| --version version for turbo | |||
|
|
|||
| Use "turbo [command] --help" for more information about a command. | |||
|
|
|||
There was a problem hiding this comment.
Just FYI I'm also testing help's output in #2379.
There was a problem hiding this comment.
I saw that. I prefer prysk/cram for tests that try to match the UI since it allows for easy updating of the snapshots using the -i flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick PR that should add some tests to make sure we're aware of how we're changing the help text with the Rust shim.
Also updated the version test so we check the version against the contents of
version.txtinstead of just making sure it matches the semver regexp.