Fix homepage images #238
Merged
Fix homepage images #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sokra
pushed a commit
that referenced
this pull request
Oct 25, 2022
These integration tests have been flaky, failing when a "free" port turns out to be in use. Since nextest parallelizes test runs and portpicker guesses and checks free ports [0], I'm guessing that there's a collision occurring. Instead, ask the operating system for a free port by binding to port 0 and read the port back from the resulting address. Test Plan: Tried local runs with nextest, but those succeeded before as well. I'll probably retry things on CI a few times. [0] https://github.com/Dentosal/portpicker-rs/blob/912f913ac325278a564d8828d550070db1d79373/src/lib.rs#L53
sokra
pushed a commit
that referenced
this pull request
Oct 25, 2022
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
These integration tests have been flaky, failing when a "free" port turns out to be in use. Since nextest parallelizes test runs and portpicker guesses and checks free ports [0], I'm guessing that there's a collision occurring. Instead, ask the operating system for a free port by binding to port 0 and read the port back from the resulting address. Test Plan: Tried local runs with nextest, but those succeeded before as well. I'll probably retry things on CI a few times. [0] https://github.com/Dentosal/portpicker-rs/blob/912f913ac325278a564d8828d550070db1d79373/src/lib.rs#L53
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
These integration tests have been flaky, failing when a "free" port turns out to be in use. Since nextest parallelizes test runs and portpicker guesses and checks free ports [0], I'm guessing that there's a collision occurring. Instead, ask the operating system for a free port by binding to port 0 and read the port back from the resulting address. Test Plan: Tried local runs with nextest, but those succeeded before as well. I'll probably retry things on CI a few times. [0] https://github.com/Dentosal/portpicker-rs/blob/912f913ac325278a564d8828d550070db1d79373/src/lib.rs#L53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.