Fix unsound with_task_id_mapping
implementation
#2362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in
with_task_id_mapping
, the ID mapping object with any lifetime is promoted to'static
through unsafe functionstd::men::transmute
. It actually assumes the object could not outlive the function, however it is possible when a panic throws in the callback, possibly causing a use-after-free from safe code.The following code snippet exhibits the undefined behaviour:
bdbai@51f4a43
Running
cargo miri test -p turbo-tasks with_task_id_mapping_panic
gives:The fix uses an RAII guard to ensure the temporary assignment is rolled back even when
func
panics.