Revamp snapshot tests #2351
Merged
Revamp snapshot tests #2351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jridgewell is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
6282dfe to
b58b0ae
Compare
wbinnssmith
approved these changes
Oct 27, 2022
alexkirsz
approved these changes
Oct 27, 2022
| let mut p = PathBuf::from(&path.await?.path); | ||
| if p.extension() == Some(OsStr::new("map")) { | ||
| p.set_extension(""); | ||
| debug_assert_ne!(p.extension(), Some(OsStr::new("js"))); |
There was a problem hiding this comment.
In what case is this possible, since we set the extension to "" just before?
There was a problem hiding this comment.
It recomputes afterwards, inheriting the next .abc123 that still remains. I think it's implemented like an rfind.
| diff.unified_diff() | ||
| .context_radius(3) | ||
| .header("expected", "actual") | ||
| ); |
There was a problem hiding this comment.
Perhaps use eprintln instead of println in the above?
The only effect is that we don't emit source maps for the individual chunk items, reducing the total number of output files considerably.
Co-authored-by: Alex Kirszenberg <a.kirszenberg@gmail.com>
4070315 to
5589628
Compare
ForsakenHarmony
approved these changes
Oct 27, 2022
Does this make it easier? I really dislike jests file format, because there's cruft alongside the snapshot outputs. |
|
Would make git diffs a bit nicer if we don't have 10 changed files for every snapshot test all the time But that doesn't have to be in this PR |
jridgewell
added a commit
to ahaoboy/turbo
that referenced
this pull request
Oct 28, 2022
jridgewell
added a commit
that referenced
this pull request
Oct 28, 2022
* chore: typo * Remove hot_module_replacement from snapshot tests Re: #2351 Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
jridgewell
added a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
* chore: typo * Remove hot_module_replacement from snapshot tests Re: vercel/turborepo#2351 Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
* chore: typo * Remove hot_module_replacement from snapshot tests Re: vercel/turborepo#2351 Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
* Disable HMR for snapshot tests The only effect is that we don't emit source maps for the individual chunk items, reducing the total number of output files considerably. * Extract snapshot tests into separate crate * Strip annoying file hash fingerprints * Reduce deps * Update old references to turbopack/test/snapshot * Move node_modules out of snapshot dir * Only un-fingerprint EcmascriptChunkSourceMapAssetVc source maps * Fix gitignore * Remove dbg * TAPLO * Apply suggestions from code review Co-authored-by: Alex Kirszenberg <a.kirszenberg@gmail.com> * Use eprintln Co-authored-by: Alex Kirszenberg <a.kirszenberg@gmail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
* chore: typo * Remove hot_module_replacement from snapshot tests Re: vercel/turborepo#2351 Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
* Disable HMR for snapshot tests The only effect is that we don't emit source maps for the individual chunk items, reducing the total number of output files considerably. * Extract snapshot tests into separate crate * Strip annoying file hash fingerprints * Reduce deps * Update old references to turbopack/test/snapshot * Move node_modules out of snapshot dir * Only un-fingerprint EcmascriptChunkSourceMapAssetVc source maps * Fix gitignore * Remove dbg * TAPLO * Apply suggestions from code review Co-authored-by: Alex Kirszenberg <a.kirszenberg@gmail.com> * Use eprintln Co-authored-by: Alex Kirszenberg <a.kirszenberg@gmail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
* chore: typo * Remove hot_module_replacement from snapshot tests Re: vercel/turborepo#2351 Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes quite a few warts with out snapshot tests:
.mapfile is renamed, making git show it as a new/deleted file instead of a changed one.build.rs, we had to rebuild theturbopackcrate whenever a test file changedturbopack(read, everything) needed to recompileturbopack-testscrate rebuilds, and everything else stays constant