Handle pnpm resolving a dependency to multiple versions #2090
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
cli/internal/context/context.go
Outdated
| @@ -277,7 +277,7 @@ func (c *Context) populateTopologicGraphForPackageJSON(pkg *fs.PackageJSON, root | |||
| pkg.TransitiveDeps = []string{} | |||
| seen := mapset.NewSet() | |||
| var lockfileWg sync.WaitGroup | |||
| c.resolveDepGraph(&lockfileWg, pkg.UnresolvedExternalDeps, externalDepSet, seen, pkg) | |||
| c.resolveDepGraph(&lockfileWg, pkg.Name, pkg.UnresolvedExternalDeps, externalDepSet, seen, pkg) | |||
There was a problem hiding this comment.
We should be passing down pkg.Dir.ToUnixPath().ToString() since both pnpm and Yarn identify workspace projects by path and not by name.
There was a problem hiding this comment.
Other thing we need to do is to special case on when pkg is the root package and pass .
There was a problem hiding this comment.
Switched to pkg.Dir and turbopath.AnchoredUnixPath
| } | ||
| importer, ok := p.Importers[workspace] | ||
| if !ok { | ||
| return "", false |
There was a problem hiding this comment.
I think we should probably panic in this scenario. If we're querying for dependencies of a non-existent workspace we're doing something wrong.
There was a problem hiding this comment.
Added a panic here, are there other comparisons in here where we should panic?
| } | ||
| } | ||
| pnpmWorkspacePath := workspacePath.ToString() | ||
| if pnpmWorkspacePath == "" { |
There was a problem hiding this comment.
Good call pushing this into the lockfile implementation
pnpmcan resolve multiple versions of a package. Resolve the package dependency specific to the workspace that asked for it.pnpm-workspace.yamlso that we don't try to resolve non-existent workspacesFixes #2075