fix(docs): overflow on <Callout />
#2082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@QuiiBz is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
Personally I prefer the word break option |
Should we wait for someone else’s opinion, or go directly with word break? |
|
@tknickman @QuiiBz Agree, word break looks better |
Updated! |
|
Thanks @mattpocock / @QuiiBz |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tknickman
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the content of
<Callout />contains long elements considered as a single word (e.g inline code), it causes an overflow on the page, and we can zoom out / swipe to the right:This PR adds an
overflow-x: scroll;to the container, which allows scrolling to the right similarly to code blocks:Screen.Recording.2022-09-26.at.15.49.53.mov
Another option is to break words, but I'm not sure if it's a better idea. The content is longer and breaks long words, such as inline code: