这是indexloc提供的服务,不要输入任何密码
Skip to content

fix(prune): place workspace configuration file in json directory #2030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

chris-olszewski
Copy link
Member

Fix for issue that @mattpocock discovered.

This places the workspace definition file into the json directory and full directory instead of the out directory. This reflects the new documentation in #2013

@vercel
Copy link

vercel bot commented Sep 21, 2022

@chris-olszewski is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@chris-olszewski chris-olszewski marked this pull request as ready for review September 21, 2022 18:20
@chris-olszewski chris-olszewski requested a review from a team as a code owner September 21, 2022 18:20
@gsoltis gsoltis added the pr: automerge Kodiak will merge these automatically after checks pass label Sep 21, 2022
@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Sep 26, 2022 at 9:24PM (UTC)

Copy link
Contributor

@mattpocock mattpocock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update the with-docker example to reflect this!

Also - is this technically a breaking change? We might break folks' current workflows.

@jaredpalmer
Copy link
Contributor

@chris-olszewski can you tackle today?

@chris-olszewski
Copy link
Member Author

Updated so we keep existing behavior, but also place the workspace file into out/json and out/full. I don't think there with-docker needs to be updated since that example uses Yarn and this change will only affect pnpm.

@mattpocock mattpocock dismissed their stale review September 27, 2022 11:06

Changes were made, so don't want to hold back the PR any more.

@kodiakhq kodiakhq bot merged commit 3c0003a into vercel:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants