这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: Add .turbo to .gitignore #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 22, 2022
Merged

fix: Add .turbo to .gitignore #2002

merged 10 commits into from
Sep 22, 2022

Conversation

NicholasLYang
Copy link
Contributor

My first task! Converts the code that adds .turbo to .gitignore from a grep command to some regular Go code. Fixes a bug with grep not detecting .turbo if there's leading or trailing whitespace.

@NicholasLYang NicholasLYang requested a review from a team as a code owner September 19, 2022 20:24
@vercel
Copy link

vercel bot commented Sep 19, 2022

Someone is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

gsoltis
gsoltis suggested changes Sep 19, 2022
View reviewed changes
@NicholasLYang NicholasLYang force-pushed the nicholasyang/turbo-282-turbo-link-modifications-to-gitignore branch from bc0b2bc to 79f4c35 Compare September 20, 2022 14:15
@gsoltis gsoltis added the pr: fixship A PR which is approved with notes and does not require re-review. label Sep 20, 2022
gsoltis
gsoltis approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@gsoltis gsoltis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one note about handling a non-existent .gitignore, then let's get this merged

@NicholasLYang NicholasLYang force-pushed the nicholasyang/turbo-282-turbo-link-modifications-to-gitignore branch from d0ab417 to f7ea9f7 Compare September 20, 2022 19:58
@NicholasLYang NicholasLYang added pr: automerge Kodiak will merge these automatically after checks pass and removed pr: fixship A PR which is approved with notes and does not require re-review. labels Sep 20, 2022
@vercel
Copy link

vercel bot commented Sep 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Sep 22, 2022 at 7:49PM (UTC)

@kodiakhq kodiakhq bot merged commit 4cc7b44 into vercel:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsoltis gsoltis gsoltis approved these changes

@nathanhammond nathanhammond Awaiting requested review from nathanhammond nathanhammond is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicholasLYang @gsoltis