这是indexloc提供的服务,不要输入任何密码
Skip to content

Use fmt.Sprintf where appropriate in logs #2068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Sep 23, 2022

The log api takes either argument pairs or a stacktrace as its varargs, but it doesn't do string formatting. Make sure we do the string formatting where we need to.

@gsoltis gsoltis requested a review from a team as a code owner September 23, 2022 19:43
@vercel
Copy link

vercel bot commented Sep 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
turbo-site ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2022 at 10:26PM (UTC)

Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gsoltis gsoltis added the pr: automerge Kodiak will merge these automatically after checks pass label Sep 23, 2022
@kodiakhq kodiakhq bot merged commit a829fd6 into main Sep 23, 2022
@kodiakhq kodiakhq bot deleted the gsoltis/fix_daemon_error_log branch September 23, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants