这是indexloc提供的服务,不要输入任何密码
Skip to content

Drop log line breaking JSON dry-run output when remote caching is enabled #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Sep 23, 2022

We shouldn't be writing directly to stdout/stderr, that breaks output for json-based commands, as well as doesn't honor any ui configuration we have in place.

Fixes #2062

@gsoltis gsoltis requested a review from a team as a code owner September 23, 2022 19:26
@vercel
Copy link

vercel bot commented Sep 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
turbo-site ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2022 at 7:44PM (UTC)

@jaredpalmer jaredpalmer added the pr: automerge Kodiak will merge these automatically after checks pass label Sep 23, 2022
@kodiakhq kodiakhq bot merged commit d48fcdf into main Sep 23, 2022
@kodiakhq kodiakhq bot deleted the gsoltis/drop_log_line branch September 23, 2022 19:52
mehulkar added a commit that referenced this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(regression) --dry-run=json does not return pure json when remote caching is enabled
2 participants