Disable windows variant #2048
Merged
Disable windows variant #2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gsoltis
commented
Sep 22, 2022
- windows is showing a "The batch file cannot be found." error that we are not currently looking into
- only run the tests if this PR changes something relevant to them.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
gaspar09
reviewed
Sep 22, 2022
.github/workflows/pr-js-tests.yml
Outdated
| @@ -30,4 +30,4 @@ jobs: | |||
| with: | |||
| github-token: "${{ secrets.GITHUB_TOKEN }}" | |||
|
|
|||
| - run: pnpm -- turbo run test --filter=!cli --color | |||
| - run: pnpm -- turbo run test --filter=...[${{ env.GITHUB_BASE_REF }}] --filter=!cli --color | |||
There was a problem hiding this comment.
env.GITHUB_BASE_REF is empty
https://github.com/vercel/turborepo/actions/runs/3107719853/jobs/5036137265#step:5:12
There was a problem hiding this comment.
I believe these are not accessed from env
https://docs.github.com/en/actions/learn-github-actions/environment-variables#:~:text=C%3A%5Chostedtoolcache%5Cwindows-,Note%3A,read%20during%20workflow%20processing%20using%20the%20%24%7B%7B%20github.ref%20%7D%7D%20context%20property.,-Detecting%20the%20operating
There was a problem hiding this comment.
hmm, not intentional.
a0c8c1b to
7c712a0
Compare
|
@gaspar09 good catch. I think I've got the right variable now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.