feat(eslint-plugin): add new configuration style #2041
Conversation
|
@iduuck is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const envVarSet = new Set( | ||
| allEnvVars.map((envVar) => envVar.slice(1, envVar.length)) | ||
| allEnvVars.map((envVar) => | ||
| envVar.startsWith("$") ? envVar.slice(1, envVar.length) : envVar |
There was a problem hiding this comment.
We don't want to clean $ from vars in env or globalEnv (because an env name with a leading $ could be a valid env var and we want to respect that). So instead of cleaning here, let's remove this altogether and move the cleaning to findDependsOnEnvVars since this will only be called for dependsOn or globalDependencies. Then we can leave env and globalEnv as is.
| @@ -9,6 +9,7 @@ const ruleTester = new RuleTester({ | |||
| const getTestTurboConfig = () => { | |||
| return { | |||
| $schema: "./docs/public/schema.json", | |||
| globalEnv: ["NEW_STYLE_GLOBAL_ENV_KEY"], | |||
There was a problem hiding this comment.
Let's add a test case where we have an env var that is prefixed with $ here and in env below.
For example,
globalEnv: ["NEW_STYLE_GLOBAL_ENV_KEY", "$NEW_STYLE_GLOBAL_ENV_KEY"],
And then this should pass:
const val = process.env["$NEW_STYLE_GLOBAL_ENV_KEY"];
There was a problem hiding this comment.
Nice catch. Didn't think of this :)
|
Thanks for the contribution @iduuck! A few quick comments, but overall looks 🔥. Thanks for being ahead of the game 😄 |
|
@tknickman Fixed this and implemented the missing $-prefixed environment variables. Thanks for the review! |
As I saw a new version popping up through my renovate integration, I updated. Though, linting is failing, since we are using the
eslint-plugin-turboplugin, and this is not yet updated to aim at the new configuration style.This PR aims to fix this.