-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Refactor core scheduler #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/8npLpd2JK4KGwsiM932r5bnpVp6N |
Closed
sokra
added a commit
that referenced
this pull request
Oct 25, 2022
explain variables using multiple lines when needed
sokra
added a commit
that referenced
this pull request
Oct 25, 2022
* update swc for nested css bugfixes * add test cases Not working yet: `@import` of CSS Modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely reimplements the task graph construction and fixes a long standing bug, which resulted in incorrect over-builds (running more tasks than necessary) and worse, incorrect builds, when the user forgot to specify the full set of possible targets.
In addition, this PR refactors Turbo's scheduler into a module which nicely separates concerns:
context.go
: Creating the topological package graph and preliminary hashingrun.go
: Determining which packages and targets are in execution scope given thepipeline
and CLI argumentsscheduler.go
: Constructing and running the orthogonal task graph given the topological graph and scopeIn practice, the scheduler's API is now abstracted into a builder pattern as follows:
API
Usage
Output
__ROOT__
is the internal name for the root node of the graph which is always necessary so that the graph always closes and there are no dangling nodes that are not connected to the rest of the graph