这是indexloc提供的服务,不要输入任何密码
Skip to content

feature(rust): bin command porting #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 90 commits into from
Oct 26, 2022
Merged

Conversation

NicholasLYang
Copy link
Contributor

Ported bin command to Rust. Also ported the help flag to Rust. NOTE: This does mean that if we change commands on the Go side, we will need to fix the Rust help screen. We can disable the Rust help flag and keep the Go one if that is too confusing.

/// Current working directory
#[clap(long, value_parser)]
/// Override the endpoint for API calls
#[clap(long, global = true, value_parser)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, forgot that cobra let you do that 🙃

@chris-olszewski chris-olszewski added the pr: fixship A PR which is approved with notes and does not require re-review. label Oct 18, 2022
Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com>
@NicholasLYang NicholasLYang added pr: automerge Kodiak will merge these automatically after checks pass and removed pr: fixship A PR which is approved with notes and does not require re-review. pr: automerge Kodiak will merge these automatically after checks pass labels Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants