-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feature(rust): bin
command porting
#2234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where --help did not work with ignore_errors
chris-olszewski
approved these changes
Oct 18, 2022
/// Current working directory | ||
#[clap(long, value_parser)] | ||
/// Override the endpoint for API calls | ||
#[clap(long, global = true, value_parser)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, forgot that cobra let you do that 🙃
Co-authored-by: Chris Olszewski <chrisdolszewski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported
bin
command to Rust. Also ported the help flag to Rust. NOTE: This does mean that if we change commands on the Go side, we will need to fix the Rust help screen. We can disable the Rust help flag and keep the Go one if that is too confusing.