这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@mehulkar
Copy link
Contributor

@mehulkar mehulkar commented Sep 13, 2022

Docs for env key updates

This PR will include:

  • guide and reference docs updates
  • blog post

This PR will be ready for review after all the code pieces are merged.

@vercel
Copy link
Contributor

vercel bot commented Sep 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
turbo-site ⬜️ Ignored (Inspect) Visit Preview Sep 21, 2022 at 9:10PM (UTC)

@mehulkar mehulkar force-pushed the mehulkar/turbo-301-update-docs-and-guides-with-env-key branch from f2fee96 to 78fc593 Compare September 13, 2022 05:51
@mehulkar mehulkar changed the title Update docs and guides on declaring env key dependencies Update docs on declaring env key dependencies Sep 13, 2022
@nathanhammond nathanhammond added the pr: on hold Pull requests that are "on hold" and should not be merged label Sep 13, 2022
Copy link
Contributor

@nathanhammond nathanhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also a number of places in /examples that would need to be updated.

@mehulkar
Copy link
Contributor Author

There are also a number of places in /examples that would need to be updated.

Do we want to put empty arrays in examples/? I only found one actual example, and it's one that isn't needed anymore after automatic inclusion

@mehulkar mehulkar force-pushed the mehulkar/turbo-301-update-docs-and-guides-with-env-key branch from be0dbf1 to 8463694 Compare September 15, 2022 08:01
kodiakhq bot pushed a commit that referenced this pull request Sep 16, 2022
This PR documents #1832 now that we're releasing it.

**Edit: Do not merge this until 1.4.7 is released**

In doing so, I'm also changing the structure of the docs to separate env and files, which also needs to happen for #1936.

One intermediate unfortunate side effect is that the docs, for some time until #1936 is merged, will document `globalDependencies` separately in two sections. This may be a little confusing during this time frame.
@tknickman tknickman force-pushed the mehulkar/turbo-301-update-docs-and-guides-with-env-key branch from 533b398 to bc7aa53 Compare September 21, 2022 18:41
@tknickman tknickman marked this pull request as ready for review September 21, 2022 18:41
@tknickman tknickman requested a review from a team as a code owner September 21, 2022 18:41
@tknickman tknickman removed the pr: on hold Pull requests that are "on hold" and should not be merged label Sep 21, 2022
@gsoltis gsoltis added the pr: automerge Kodiak will merge these automatically after checks pass label Sep 21, 2022
@kodiakhq kodiakhq bot merged commit 0dfa8e6 into main Sep 21, 2022
@kodiakhq kodiakhq bot deleted the mehulkar/turbo-301-update-docs-and-guides-with-env-key branch September 21, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: automerge Kodiak will merge these automatically after checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants