-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix broken links on "Add to existing Monorepo" #1836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Same reason as [this commit](675ee01) - In case of `turbo run` link, change hash from `#turbo-run-task1-task2-1` to `#turbo-run-task` because the former is no longer existed
@pakaponk is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I really appreciate your attention to detail. To answer your question: yes, if we still have links that result in an immediate redirect we should update to the new canonical URL. |
- Change `../features/*` to `../core-concepts/*`
Thanks. I just changed them in the latest commit. |
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [turbo](https://turborepo.org) ([source](https://togithub.com/vercel/turborepo)) | [`^1.4.3` -> `^1.4.6`](https://renovatebot.com/diffs/npm/turbo/1.4.3/1.4.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turborepo</summary> ### [`v1.4.6`](https://togithub.com/vercel/turborepo/releases/tag/v1.4.6) [Compare Source](https://togithub.com/vercel/turborepo/compare/v1.4.5...v1.4.6) #### What's Changed ##### Internal - fix(deps): update dependency ora to v4.1.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1854](https://togithub.com/vercel/turborepo/pull/1854) - Don't special case version command by [@​gsoltis](https://togithub.com/gsoltis) in [https://github.com/vercel/turborepo/pull/1870](https://togithub.com/vercel/turborepo/pull/1870) - fix(deps): update dependency react-hot-toast to v2.3.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1875](https://togithub.com/vercel/turborepo/pull/1875) - chore(deps): update jamesives/github-pages-deploy-action action to v4.4.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1851](https://togithub.com/vercel/turborepo/pull/1851) - chore(deps): update dependency typescript to v4.8.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1849](https://togithub.com/vercel/turborepo/pull/1849) - chore(deps): update dependency esbuild to ^0.15.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1848](https://togithub.com/vercel/turborepo/pull/1848) - Enable pnpm@6 testing. by [@​7flash](https://togithub.com/7flash) in [https://github.com/vercel/turborepo/pull/1837](https://togithub.com/vercel/turborepo/pull/1837) - fix(deps): update dependency eslint-plugin-react to v7.31.7 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1834](https://togithub.com/vercel/turborepo/pull/1834) - chore(deps): update dependency [@​types/react](https://togithub.com/types/react) to v17.0.49 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1833](https://togithub.com/vercel/turborepo/pull/1833) - Replace some 2 letter variables for readability by [@​mehulkar](https://togithub.com/mehulkar) in [https://github.com/vercel/turborepo/pull/1845](https://togithub.com/vercel/turborepo/pull/1845) ##### Documentation - Remove unused packages from docs site by [@​mehulkar](https://togithub.com/mehulkar) in [https://github.com/vercel/turborepo/pull/1828](https://togithub.com/vercel/turborepo/pull/1828) - Consolidated 'workspace' and 'package' terminology by [@​mattpocock](https://togithub.com/mattpocock) in [https://github.com/vercel/turborepo/pull/1817](https://togithub.com/vercel/turborepo/pull/1817) - Rewrote docs homepage by [@​mattpocock](https://togithub.com/mattpocock) in [https://github.com/vercel/turborepo/pull/1756](https://togithub.com/vercel/turborepo/pull/1756) - Update existing-monorepo.mdx by [@​shemayas](https://togithub.com/shemayas) in [https://github.com/vercel/turborepo/pull/1858](https://togithub.com/vercel/turborepo/pull/1858) - Update Docs by [@​PhentomPT](https://togithub.com/PhentomPT) in [https://github.com/vercel/turborepo/pull/1794](https://togithub.com/vercel/turborepo/pull/1794) - Fix broken links on "Add to existing Monorepo" by [@​pakaponk](https://togithub.com/pakaponk) in [https://github.com/vercel/turborepo/pull/1836](https://togithub.com/vercel/turborepo/pull/1836) ##### Examples - Removed parallel flag from basic example by [@​mattpocock](https://togithub.com/mattpocock) in [https://github.com/vercel/turborepo/pull/1787](https://togithub.com/vercel/turborepo/pull/1787) - Renamed storybook components by [@​samuelhorn](https://togithub.com/samuelhorn) in [https://github.com/vercel/turborepo/pull/1841](https://togithub.com/vercel/turborepo/pull/1841) ##### Packages - fix(eslint): exclude variables in rule by [@​tknickman](https://togithub.com/tknickman) in [https://github.com/vercel/turborepo/pull/1865](https://togithub.com/vercel/turborepo/pull/1865) #### New Contributors - [@​shemayas](https://togithub.com/shemayas) made their first contribution in [https://github.com/vercel/turborepo/pull/1858](https://togithub.com/vercel/turborepo/pull/1858) - [@​7flash](https://togithub.com/7flash) made their first contribution in [https://github.com/vercel/turborepo/pull/1837](https://togithub.com/vercel/turborepo/pull/1837) - [@​PhentomPT](https://togithub.com/PhentomPT) made their first contribution in [https://github.com/vercel/turborepo/pull/1794](https://togithub.com/vercel/turborepo/pull/1794) **Full Changelog**: vercel/turborepo@v1.4.5...v1.4.6 ### [`v1.4.5`](https://togithub.com/vercel/turborepo/releases/tag/v1.4.5) [Compare Source](https://togithub.com/vercel/turborepo/compare/v1.4.4...v1.4.5) #### What's Changed ##### Core - Split notion of logged in into user and linked-team by [@​gsoltis](https://togithub.com/gsoltis) in [https://github.com/vercel/turborepo/pull/1844](https://togithub.com/vercel/turborepo/pull/1844) ##### Documentation - Turborepo usage. by [@​nathanhammond](https://togithub.com/nathanhammond) in [https://github.com/vercel/turborepo/pull/1827](https://togithub.com/vercel/turborepo/pull/1827) - Remove unused [@​react-aria/radio](https://togithub.com/react-aria/radio) package by [@​mehulkar](https://togithub.com/mehulkar) in [https://github.com/vercel/turborepo/pull/1826](https://togithub.com/vercel/turborepo/pull/1826) - Fix broken links at "Next Steps" on "Add to Existing Monorepo" by [@​pakaponk](https://togithub.com/pakaponk) in [https://github.com/vercel/turborepo/pull/1835](https://togithub.com/vercel/turborepo/pull/1835) - Upgrade Nextra by [@​shuding](https://togithub.com/shuding) in [https://github.com/vercel/turborepo/pull/1831](https://togithub.com/vercel/turborepo/pull/1831) **Full Changelog**: vercel/turborepo@v1.4.4...v1.4.5 ### [`v1.4.4`](https://togithub.com/vercel/turborepo/compare/v1.4.3...v1.4.4) [Compare Source](https://togithub.com/vercel/turborepo/compare/v1.4.3...v1.4.4) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/BirthdayResearch/contented). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xODYuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE5NC4yIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [turbo](https://turborepo.org) ([source](https://togithub.com/vercel/turborepo)) | [`^1.4.5` -> `^1.4.6`](https://renovatebot.com/diffs/npm/turbo/1.4.5/1.4.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turborepo</summary> ### [`v1.4.6`](https://togithub.com/vercel/turborepo/releases/tag/v1.4.6) [Compare Source](https://togithub.com/vercel/turborepo/compare/v1.4.5...v1.4.6) #### What's Changed ##### Internal - fix(deps): update dependency ora to v4.1.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1854](https://togithub.com/vercel/turborepo/pull/1854) - Don't special case version command by [@​gsoltis](https://togithub.com/gsoltis) in [https://github.com/vercel/turborepo/pull/1870](https://togithub.com/vercel/turborepo/pull/1870) - fix(deps): update dependency react-hot-toast to v2.3.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1875](https://togithub.com/vercel/turborepo/pull/1875) - chore(deps): update jamesives/github-pages-deploy-action action to v4.4.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1851](https://togithub.com/vercel/turborepo/pull/1851) - chore(deps): update dependency typescript to v4.8.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1849](https://togithub.com/vercel/turborepo/pull/1849) - chore(deps): update dependency esbuild to ^0.15.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1848](https://togithub.com/vercel/turborepo/pull/1848) - Enable pnpm@6 testing. by [@​7flash](https://togithub.com/7flash) in [https://github.com/vercel/turborepo/pull/1837](https://togithub.com/vercel/turborepo/pull/1837) - fix(deps): update dependency eslint-plugin-react to v7.31.7 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1834](https://togithub.com/vercel/turborepo/pull/1834) - chore(deps): update dependency [@​types/react](https://togithub.com/types/react) to v17.0.49 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1833](https://togithub.com/vercel/turborepo/pull/1833) - Replace some 2 letter variables for readability by [@​mehulkar](https://togithub.com/mehulkar) in [https://github.com/vercel/turborepo/pull/1845](https://togithub.com/vercel/turborepo/pull/1845) ##### Documentation - Remove unused packages from docs site by [@​mehulkar](https://togithub.com/mehulkar) in [https://github.com/vercel/turborepo/pull/1828](https://togithub.com/vercel/turborepo/pull/1828) - Consolidated 'workspace' and 'package' terminology by [@​mattpocock](https://togithub.com/mattpocock) in [https://github.com/vercel/turborepo/pull/1817](https://togithub.com/vercel/turborepo/pull/1817) - Rewrote docs homepage by [@​mattpocock](https://togithub.com/mattpocock) in [https://github.com/vercel/turborepo/pull/1756](https://togithub.com/vercel/turborepo/pull/1756) - Update existing-monorepo.mdx by [@​shemayas](https://togithub.com/shemayas) in [https://github.com/vercel/turborepo/pull/1858](https://togithub.com/vercel/turborepo/pull/1858) - Update Docs by [@​PhentomPT](https://togithub.com/PhentomPT) in [https://github.com/vercel/turborepo/pull/1794](https://togithub.com/vercel/turborepo/pull/1794) - Fix broken links on "Add to existing Monorepo" by [@​pakaponk](https://togithub.com/pakaponk) in [https://github.com/vercel/turborepo/pull/1836](https://togithub.com/vercel/turborepo/pull/1836) ##### Examples - Removed parallel flag from basic example by [@​mattpocock](https://togithub.com/mattpocock) in [https://github.com/vercel/turborepo/pull/1787](https://togithub.com/vercel/turborepo/pull/1787) - Renamed storybook components by [@​samuelhorn](https://togithub.com/samuelhorn) in [https://github.com/vercel/turborepo/pull/1841](https://togithub.com/vercel/turborepo/pull/1841) ##### Packages - fix(eslint): exclude variables in rule by [@​tknickman](https://togithub.com/tknickman) in [https://github.com/vercel/turborepo/pull/1865](https://togithub.com/vercel/turborepo/pull/1865) #### New Contributors - [@​shemayas](https://togithub.com/shemayas) made their first contribution in [https://github.com/vercel/turborepo/pull/1858](https://togithub.com/vercel/turborepo/pull/1858) - [@​7flash](https://togithub.com/7flash) made their first contribution in [https://github.com/vercel/turborepo/pull/1837](https://togithub.com/vercel/turborepo/pull/1837) - [@​PhentomPT](https://togithub.com/PhentomPT) made their first contribution in [https://github.com/vercel/turborepo/pull/1794](https://togithub.com/vercel/turborepo/pull/1794) **Full Changelog**: vercel/turborepo@v1.4.5...v1.4.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/DeFiCh/metachain). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTQuMyIsInVwZGF0ZWRJblZlciI6IjMyLjE5NC4zIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [turbo](https://turborepo.org) ([source](https://togithub.com/vercel/turborepo)) | [`^1.4.5` -> `^1.4.6`](https://renovatebot.com/diffs/npm/turbo/1.4.5/1.4.6) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vercel/turborepo</summary> ### [`v1.4.6`](https://togithub.com/vercel/turborepo/releases/tag/v1.4.6) [Compare Source](https://togithub.com/vercel/turborepo/compare/v1.4.5...v1.4.6) #### What's Changed ##### Internal - fix(deps): update dependency ora to v4.1.1 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1854](https://togithub.com/vercel/turborepo/pull/1854) - Don't special case version command by [@​gsoltis](https://togithub.com/gsoltis) in [https://github.com/vercel/turborepo/pull/1870](https://togithub.com/vercel/turborepo/pull/1870) - fix(deps): update dependency react-hot-toast to v2.3.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1875](https://togithub.com/vercel/turborepo/pull/1875) - chore(deps): update jamesives/github-pages-deploy-action action to v4.4.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1851](https://togithub.com/vercel/turborepo/pull/1851) - chore(deps): update dependency typescript to v4.8.2 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1849](https://togithub.com/vercel/turborepo/pull/1849) - chore(deps): update dependency esbuild to ^0.15.0 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1848](https://togithub.com/vercel/turborepo/pull/1848) - Enable pnpm@6 testing. by [@​7flash](https://togithub.com/7flash) in [https://github.com/vercel/turborepo/pull/1837](https://togithub.com/vercel/turborepo/pull/1837) - fix(deps): update dependency eslint-plugin-react to v7.31.7 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1834](https://togithub.com/vercel/turborepo/pull/1834) - chore(deps): update dependency [@​types/react](https://togithub.com/types/react) to v17.0.49 by [@​renovate](https://togithub.com/renovate) in [https://github.com/vercel/turborepo/pull/1833](https://togithub.com/vercel/turborepo/pull/1833) - Replace some 2 letter variables for readability by [@​mehulkar](https://togithub.com/mehulkar) in [https://github.com/vercel/turborepo/pull/1845](https://togithub.com/vercel/turborepo/pull/1845) ##### Documentation - Remove unused packages from docs site by [@​mehulkar](https://togithub.com/mehulkar) in [https://github.com/vercel/turborepo/pull/1828](https://togithub.com/vercel/turborepo/pull/1828) - Consolidated 'workspace' and 'package' terminology by [@​mattpocock](https://togithub.com/mattpocock) in [https://github.com/vercel/turborepo/pull/1817](https://togithub.com/vercel/turborepo/pull/1817) - Rewrote docs homepage by [@​mattpocock](https://togithub.com/mattpocock) in [https://github.com/vercel/turborepo/pull/1756](https://togithub.com/vercel/turborepo/pull/1756) - Update existing-monorepo.mdx by [@​shemayas](https://togithub.com/shemayas) in [https://github.com/vercel/turborepo/pull/1858](https://togithub.com/vercel/turborepo/pull/1858) - Update Docs by [@​PhentomPT](https://togithub.com/PhentomPT) in [https://github.com/vercel/turborepo/pull/1794](https://togithub.com/vercel/turborepo/pull/1794) - Fix broken links on "Add to existing Monorepo" by [@​pakaponk](https://togithub.com/pakaponk) in [https://github.com/vercel/turborepo/pull/1836](https://togithub.com/vercel/turborepo/pull/1836) ##### Examples - Removed parallel flag from basic example by [@​mattpocock](https://togithub.com/mattpocock) in [https://github.com/vercel/turborepo/pull/1787](https://togithub.com/vercel/turborepo/pull/1787) - Renamed storybook components by [@​samuelhorn](https://togithub.com/samuelhorn) in [https://github.com/vercel/turborepo/pull/1841](https://togithub.com/vercel/turborepo/pull/1841) ##### Packages - fix(eslint): exclude variables in rule by [@​tknickman](https://togithub.com/tknickman) in [https://github.com/vercel/turborepo/pull/1865](https://togithub.com/vercel/turborepo/pull/1865) #### New Contributors - [@​shemayas](https://togithub.com/shemayas) made their first contribution in [https://github.com/vercel/turborepo/pull/1858](https://togithub.com/vercel/turborepo/pull/1858) - [@​7flash](https://togithub.com/7flash) made their first contribution in [https://github.com/vercel/turborepo/pull/1837](https://togithub.com/vercel/turborepo/pull/1837) - [@​PhentomPT](https://togithub.com/PhentomPT) made their first contribution in [https://github.com/vercel/turborepo/pull/1794](https://togithub.com/vercel/turborepo/pull/1794) **Full Changelog**: vercel/turborepo@v1.4.5...v1.4.6 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/DeFiCh/metachain). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTQuMyIsInVwZGF0ZWRJblZlciI6IjMyLjE5NC4zIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Summary
turbo run
link, change the hash from#turbo-run-task1-task2-1
to#turbo-run-task
because the former no longer existsPage: https://turborepo.org/docs/getting-started/existing-monorepo
Question
../features/*
in the relative paths to../core-concepts/*
?/features/*
path is redirected to/core-concepts/*
path due to the Next.js redirect config.