chore(packages): typecheck and abstract ts config #1807
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0d3364b to
895101c
Compare
895101c to
14fce44
Compare
14fce44 to
2904041
Compare
2904041 to
ba32e56
Compare
| "@types/semver": "^7.3.9", | ||
| "eslint": "^7.23.0", | ||
| "jest": "^27.4.3", | ||
| "semver": "^7.3.5", | ||
| "strip-ansi": "^6.0.1", | ||
| "ts-jest": "^27.1.1", | ||
| "tsconfig": "workspace:*", |
There was a problem hiding this comment.
WE HAVE OUR OWN NOW! 🎉
| @@ -1,17 +1,6 @@ | |||
| { | |||
| "exclude": ["templates"], | |||
| "compilerOptions": { | ||
| "lib": ["ES2019"], | ||
| "target": "ES2019", | ||
| "skipLibCheck": true, |
There was a problem hiding this comment.
I think this is unnecessary?
There was a problem hiding this comment.
Details about why we have this: evanw/esbuild#2388
Will add a comment about this as well
| "name": "tsconfig", | ||
| "version": "0.0.0", | ||
| "private": true, | ||
| "main": "index.js" |
There was a problem hiding this comment.
This file doesn't exist.
There was a problem hiding this comment.
Yep I knew this. This is how the tsconfig is configured in our examples and thought at one point that this was a hack to get autocompletion working, but Jared and I disproved that a while ago so I'll take it out everywhere.
| "dependencies": { | ||
| "@manypkg/find-root": "^1.1.0", | ||
| "turbo-utils": "workspace:*" | ||
| }, |
There was a problem hiding this comment.
Since we're running the build for this in advance, moving these into dependencies now conflicts with:
"build": "tsup && cp ./package.json ./dist/package.json",
There was a problem hiding this comment.
Excellent catch - it shouldn't technically be a problem - but install times will be slower for anyone using npx (or equivalent). will fix
| }, | ||
| "devDependencies": { | ||
| "@manypkg/find-root": "^1.1.0", | ||
| "@types/jest": "^27.4.0", | ||
| "@types/node": "^16.11.12", | ||
| "esbuild": "^0.14.38", | ||
| "eslint": "^8.23.0", |
There was a problem hiding this comment.
I personally like how the diff resolves to look like you replaced esbuild with eslint.
There was a problem hiding this comment.
Lol, this was in an effort to fix the skipLibCheck issue that you also pointed out. But it doesn't matter since it comes in via tsup anyway.
This was added as part of #1807, but lost in one of our CI updates.
This PR includes some packages maintenance: