这是indexloc提供的服务，不要输入任何密码
Skip to content

Remove --no-gc flag, always run with garbage collection #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 31, 2022
Merged

Remove --no-gc flag, always run with garbage collection #1803

merged 6 commits into from
Aug 31, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Aug 29, 2022 •
edited
Loading

This PR:

  • Removes the --no-gc flag
  • Makes using the GC the default.

A parsing bug meant no one was using --no-gc, so use this opportunity to enable GC. Benchmarks show negligible difference in execution time.

@gsoltis gsoltis requested a review from a team as a code owner August 29, 2022 21:00
@vercel
Copy link

vercel bot commented Aug 29, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
turbo-site ⬜️ Ignored (Inspect) Visit Preview Aug 31, 2022 at 0:49AM (UTC)

@gsoltis gsoltis marked this pull request as draft August 29, 2022 21:54
@gsoltis gsoltis force-pushed the gsoltis/fix_no_gc branch from e6aabf1 to a67f3e9 Compare August 29, 2022 21:58
@gsoltis gsoltis marked this pull request as ready for review August 29, 2022 22:01
@gsoltis gsoltis changed the title Fix flag parsing for boolean flag no-gc Remove --no-gc flag, always run with garbage collection Aug 30, 2022
tknickman
tknickman approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@tknickman tknickman added the pr: automerge Kodiak will merge these automatically after checks pass label Aug 31, 2022
@kodiakhq kodiakhq bot merged commit 750d3a7 into main Aug 31, 2022
@kodiakhq kodiakhq bot deleted the gsoltis/fix_no_gc branch August 31, 2022 03:29
@renovate renovate bot mentioned this pull request Oct 21, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanhammond nathanhammond nathanhammond approved these changes

@mehulkar mehulkar mehulkar approved these changes

@tknickman tknickman tknickman approved these changes

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gsoltis @nathanhammond @mehulkar @tknickman