这是indexloc提供的服务,不要输入任何密码
Skip to content

Drop unused absolute unix path #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Drop unused absolute unix path #1791

merged 2 commits into from
Aug 29, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Aug 26, 2022

We don't use, and probably should not use, absolute unix paths. Unix paths are for sharing across machines, and absolute paths are for interacting with the local machine and should always be system paths.

@vercel
Copy link

vercel bot commented Aug 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Aug 29, 2022 at 10:55AM (UTC)

@gsoltis gsoltis marked this pull request as ready for review August 26, 2022 21:21
@gsoltis gsoltis requested a review from a team as a code owner August 26, 2022 21:21
Copy link
Contributor

@nathanhammond nathanhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that we should not use this. Exists as a cross-product item.

@nathanhammond nathanhammond added the pr: automerge Kodiak will merge these automatically after checks pass label Aug 29, 2022
@kodiakhq kodiakhq bot merged commit a05816f into main Aug 29, 2022
@kodiakhq kodiakhq bot deleted the gsoltis/drop_abs_unix_path branch August 29, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants