Set cmd.Dir to an absolute path when we execute scripts #1774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
db96142 to
c2cac53
Compare
6ad41e7 to
adf42d8
Compare
adf42d8 to
f88cf5e
Compare
mehulkar
approved these changes
Aug 30, 2022
| runCache: runCache, | ||
| logger: r.config.Logger, | ||
| packageManager: packageManager, | ||
| processes: r.processes, | ||
| taskHashes: hashes, | ||
| repoRoot: r.config.Cwd, |
There was a problem hiding this comment.
Saw some chatter about cwd when turbo is run from a directory other than root of monorepo. Is r.config.Cwd here always "root of monorepo" or can it be different?
There was a problem hiding this comment.
Yes, we resolve Config.Cwd to either the program's working directory, or the value of the --cwd flag. In the upcoming cobra port, this gets renamed to RepoRoot to hopefully be more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
cmd.Dirto an absolute path ensures that it will continue to work in the presence of the--cwdflag.Bonus drop unused
turboCachefromexecContext.Note that this PR stacks on top of #1773