这是indexloc提供的服务,不要输入任何密码
Skip to content

Run benchmarks, push data to tinybird and gh-pages #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 17, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Aug 17, 2022

New revision of the large monorepo benchmark. Still set to manual. Produces both benchmark-action-compatible json as well as tinybird-compatible ndjson.

Sends ndjson to tinybird and json to gh-pages.

Tested on my own fork of the repo.

@vercel
Copy link

vercel bot commented Aug 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Aug 17, 2022 at 9:38PM (UTC)

@@ -4,12 +4,13 @@
"dependencies": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe doesn't totally fit the mold - but It might be nice to move this to packages/ in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, might make sense.

@tknickman tknickman added the pr: on hold Pull requests that are "on hold" and should not be merged label Aug 17, 2022
Copy link
Contributor

@mehulkar mehulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Just for my understanding, why do we push to both Tinybird and gh-pages branch?

@gsoltis
Copy link
Contributor Author

gsoltis commented Aug 17, 2022

@mehulkar the github action keeps a json file up to date and provides a template we can eventually use to make nice graphs. Tinybird is for our own internal analysis

@gsoltis gsoltis removed the pr: on hold Pull requests that are "on hold" and should not be merged label Aug 17, 2022
@gsoltis gsoltis added the pr: automerge Kodiak will merge these automatically after checks pass label Aug 17, 2022
@kodiakhq kodiakhq bot merged commit 7bfa00e into main Aug 17, 2022
@kodiakhq kodiakhq bot deleted the gsoltis/prod_benchmark branch August 17, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants