这是indexloc提供的服务,不要输入任何密码
Skip to content

Add yarn/berry switch in create-turbo tests. #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 17, 2022

Conversation

nathanhammond
Copy link
Contributor

@nathanhammond nathanhammond commented Aug 17, 2022

This would be somewhat cleaned up in a corepack world.

@vercel
Copy link

vercel bot commented Aug 17, 2022

@nathanhammond is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Aug 17, 2022 at 7:59PM (UTC)

Copy link
Contributor

@mehulkar mehulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense, thanks 👍🏾. Getting parallels set up for myself also

@@ -325,10 +331,27 @@ function cleanupTestDir() {
if (fs.existsSync(testDir)) {
fs.rmSync(testDir, { recursive: true });
}
fs.rmSync(path.join(__dirname, "../.yarn"), { recursive: true, force: true });
fs.rmSync(path.join(__dirname, "../.yarnrc"), { force: true });
fs.rmSync(path.join(__dirname, "../.yarnrc.yml"), { force: true });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these getting created because of yarn set version?

@kodiakhq kodiakhq bot merged commit a2b2fc6 into vercel:main Aug 17, 2022
@nathanhammond
Copy link
Contributor Author

oh no, this is in a broken state! Let me get a new PR up...

@nathanhammond
Copy link
Contributor Author

(sorry, didn't expect this to get merged as I kept pulling and pulling on the thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants