这是indexloc提供的服务,不要输入任何密码
Skip to content

Autofix fixable lint issues #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 23, 2022
Merged

Autofix fixable lint issues #1748

merged 5 commits into from
Aug 23, 2022

Conversation

mehulkar
Copy link
Contributor

We have a ton of lint errors not getting caught in CI right now, because it only runs lint on new code every PR. This at least runs the lint and fixes things that can be fixed automatically.

golangci-lint run --fix

@mehulkar mehulkar requested a review from a team as a code owner August 23, 2022 18:20
@mehulkar mehulkar requested review from gsoltis and tknickman August 23, 2022 18:20
@vercel
Copy link

vercel bot commented Aug 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
turbo-site ⬜️ Ignored (Inspect) Visit Preview Aug 23, 2022 at 11:11PM (UTC)

Copy link
Contributor

@gsoltis gsoltis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, chrometracing and doublestar are libraries we adopted to make some tweaks to. But automated fixes for fewer lint errors seems fine.

@mehulkar mehulkar merged commit 39f9fb5 into main Aug 23, 2022
@mehulkar mehulkar deleted the mk/linter branch August 23, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants