这是indexloc提供的服务，不要输入任何密码
Skip to content

docs: fix turbo prune with docker blog example #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 8, 2022
Merged

docs: fix turbo prune with docker blog example #1596

merged 10 commits into from
Aug 8, 2022

Conversation

erj826
Copy link
Contributor

@erj826 erj826 commented Jul 29, 2022 •
edited
Loading

This updates the turbo prune with docker multi-stage builds example from the 0.4.0 release blog post so that it can be run without errors. See the Github comments for further explanation.

@vercel
Copy link

vercel bot commented Jul 29, 2022

Someone is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@erj826 erj826 changed the title Fix Turbo Prune Docker Example [WIP] Fix Turbo Prune Docker Example Jul 29, 2022
@erj826 erj826 changed the title [WIP] Fix Turbo Prune Docker Example [WIP] Update Turbo Prune Docs and Fix Blog Example Jul 29, 2022
@erj826 erj826 changed the title [WIP] Update Turbo Prune Docs and Fix Blog Example Update Turbo Prune Docs and Fix Blog Example Jul 29, 2022
erj826
erj826 commented Jul 29, 2022
View reviewed changes
erj826
erj826 commented Jul 29, 2022
View reviewed changes
erj826
erj826 commented Jul 29, 2022
View reviewed changes
erj826
erj826 commented Jul 29, 2022
View reviewed changes
erj826
erj826 commented Jul 29, 2022
View reviewed changes
erj826
erj826 commented Jul 29, 2022
View reviewed changes
erj826
erj826 commented Jul 29, 2022
View reviewed changes
@erj826 erj826 changed the title Update Turbo Prune Docs and Fix Blog Example Fix Turbo Prune with Docker Blog Example Jul 29, 2022
erj826
erj826 commented Jul 29, 2022
View reviewed changes
@tknickman tknickman self-assigned this Jul 29, 2022
@tknickman tknickman added the area: examples Improvements or additions to examples label Jul 29, 2022
@erj826 erj826 marked this pull request as ready for review July 29, 2022 17:09
@erj826 erj826 changed the title Fix Turbo Prune with Docker Blog Example docs: fix turbo prune with docker blog example Jul 30, 2022
@vercel
Copy link

vercel bot commented Aug 8, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
turbo-site ✅ Ready (Inspect) Visit Preview Aug 8, 2022 at 5:11PM (UTC)

tknickman
tknickman requested changes Aug 8, 2022
View reviewed changes
Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on the review here, just a few minor comments but otherwise looks great - thank for updating this!

tknickman
tknickman approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tknickman tknickman added the pr: automerge Kodiak will merge these automatically after checks pass label Aug 8, 2022
@kodiakhq kodiakhq bot merged commit 9346c65 into vercel:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finn-orsini finn-orsini finn-orsini left review comments

@tknickman tknickman tknickman approved these changes

@jaredpalmer jaredpalmer Awaiting requested review from jaredpalmer

@gsoltis gsoltis Awaiting requested review from gsoltis

@gaspar09 gaspar09 Awaiting requested review from gaspar09

@nathanhammond nathanhammond Awaiting requested review from nathanhammond

@chris-olszewski chris-olszewski Awaiting requested review from chris-olszewski

@mehulkar mehulkar Awaiting requested review from mehulkar

Assignees

@tknickman tknickman

Labels
area: examples Improvements or additions to examples pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erj826 @tknickman @finn-orsini